-
Notifications
You must be signed in to change notification settings - Fork 685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pre-commit configuration for gersemi #1670
Conversation
…into fix-gersemi
@@ -41,6 +41,7 @@ repos: | |||
rev: 0.17.1 | |||
hooks: | |||
- id: gersemi | |||
args: ["-c"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This ensures that gersemi run in check mode which returns 1 if any formatting required and 0 otherwise
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1670 +/- ##
=======================================
Coverage 83.15% 83.15%
=======================================
Files 277 277
Lines 48193 48193
Branches 9949 9932 -17
=======================================
Hits 40077 40077
+ Misses 7225 7220 -5
- Partials 891 896 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
* fix pre-commit configuration * pre-commit fixes * improve exclude more * apply fixes
Currently all txt files are excluded which prevents fixing of CMake files (which not noticed by me in #1602 unfortunately). This PR should fix this issue