fixes a use-of-uninitialized-value in light_pcapng.c #1669
Conversation
|
Hii @seladb Could You please Review this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1669 +/- ##
==========================================
- Coverage 83.15% 83.15% -0.01%
==========================================
Files 277 277
Lines 48193 48201 +8
Branches 9949 9920 -29
==========================================
+ Hits 40077 40083 +6
+ Misses 7225 7223 -2
- Partials 891 895 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@Shivam7-1 Could you only modify the necessary parts? Try to minimiaze the lines of changes ... |
| current->options = opt; | ||
| } | ||
| break; | ||
| void parse_by_block_type(struct _light_pcapng *current, const uint32_t *local_data, const uint32_t *block_start) { |
There was a problem hiding this comment.
Don't change the format. Same for all other lines.
Hii where I could see CI issue or find out |
@Shivam7-1 as @tigercosmos commented, please try only to change specific lines and avoid changing the formatting. LightPcapNg is a 3rd party library so we try to make minimal change in it |
Hii @seladb @tigercosmos Thanks For Reviewing I had Done this Changes and avoided any changes in formatting it can reviewed here https://github.com/seladb/PcapPlusPlus/pull/1669/files |
|
Thank you @Shivam7-1 for working on this fix, much appreciated! 🙏 |
Hii Thanks to you also and Team for Continuous Support and feedback |
This PR fixes a use-of-uninitialized-value vulnerability in light_pcapng.c. The changes ensure all allocated memory is properly initialized before use, mitigating potential crashes and undefined behavior.
Issue: https://issues.oss-fuzz.com/issues/42536106
Reproducer Testcase: https://oss-fuzz.com/download?testcase_id=6639796737867776