Port Pcap++ code to use override, part of #977 #1369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…actor/pcap-cpp11-modernization
rtmeng
changed the title
rtmeng
force-pushed
the
refactor/pcap-cpp11-modernization
branch
from
c79ae8b to
18a666c
Compare
tigercosmos
approved these changes
Apr 19, 2024
seladb
approved these changes
Apr 21, 2024
|
Thank you @rtmeng for opening this PR, much appreciated! 💯 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates Pcap++ to use override where applicable for readability, clarity and safety. It is a part of Issue #977 to change more parts of the code to C++11 for improved performance and readability. For testing, ensured that all existing tests still passed.