Port tutorial codes to C++11, fixing issue #977 partially #1358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merttozer
force-pushed
the
port-cpp11-issue-977
branch
from
d0b42cd to
298e60e
Compare
tigercosmos
reviewed
Apr 14, 2024
| columnLengths.push_back(15); | ||
| columnLengths.push_back(15); | ||
| columnLengths.push_back(15); | ||
| std::vector<std::string> columnNames = {" ", "Total Packets", "Packets/sec", "Bytes", "Bits/sec"}; |
| @@ -74,7 +72,7 @@ struct PacketStats | |||
| static void onPacketArrives(pcpp::RawPacket* packet, pcpp::PcapLiveDevice* dev, void* cookie) | |||
| { | |||
| // extract the stats object form the cookie | |||
| PacketStats* stats = (PacketStats*)cookie; | |||
| auto* stats = static_cast<PacketStats*>(cookie); | |||
There was a problem hiding this comment.
auto here make sense.
There was a problem hiding this comment.
IMO, the sensible thing here is to use static casting instead of c-style casting.
|
|
||
| if (dev->getDnsServers().size() > 0) | ||
| std::cout << " DNS server: " << dev->getDnsServers().at(0) << std::endl; | ||
| if (!dev->getDnsServers().empty()) |
egecetin
reviewed
Apr 14, 2024
| { | ||
| workersCoreMask = workersCoreMask | (1 << i); | ||
| } | ||
| int workersCoreMask = 0x06; // Binary 110, using cores 1 and 2 |
There was a problem hiding this comment.
It is cleaner but I'm not sure it is more beginner friendly. The for-loop implementation shows that people might set mask by using bit shifting but the updated version only shows as a constant. Since this is a tutorial code, I'm not sure which one is better.
egecetin
approved these changes
Apr 16, 2024
seladb
reviewed
Apr 17, 2024
merttozer
force-pushed
the
port-cpp11-issue-977
branch
from
92e80a7 to
41db8c4
Compare
seladb
approved these changes
Apr 18, 2024
|
@merttozer thank you so much for working on it, much appreciated! 🙏 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces updates to the PcapPlusPlus tutorial codes, transitioning them to utilize C++11 features for improved performance and readability. The changes align with modern C++ standards and address the requirements specified in Issue #977.
Key Changes:
Testing: