-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add regresssion_samples explanation #1230
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1230 +/- ##
==========================================
- Coverage 82.73% 82.72% -0.01%
==========================================
Files 159 159
Lines 20294 20294
Branches 7668 7668
==========================================
- Hits 16791 16789 -2
Misses 2884 2884
- Partials 619 621 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
.pre-commit-config.yaml
Outdated
@@ -5,6 +5,7 @@ repos: | |||
rev: v4.5.0 | |||
hooks: | |||
- id: trailing-whitespace | |||
args: [--markdown-linebreak-ext=md] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this change needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because two spaces at the end is a valid markdown line-break syntax. Pre-commit was too aggressive for markdown files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While two spaces at the end is a valid markdown line-break, it's not considered a best practice: https://www.markdownguide.org/basic-syntax/#line-break-best-practices
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, The best practice is to mix html with markdown?? Just saying - https://grep.app/search?q=--markdown-linebreak-ext&filter[lang][0]=YAML
Anyway, as you wish, I have reverted it.
No description provided.