Move 3rdParty GetOpt to Examples subdir and add weekly test build with vcpkg

[clementperon]

Hi,

In order to regularly check that the vcpkg package manager is not broken add a CI workflow that test to build the Examples with PcapPlusPLus installed using vcpkg.

In order to build out-of-tree on Windows the getopt library needs to be moved to Examples directory

Also bump the checkout action to v4 everywhere.

DRAFT: Until vcpkg 23.09 is merged on vcpkg repo and move to official vcpkg repo instead of clementperon's fork

[codecov]

Codecov Report

Merging #1226 (3ad183d) into dev (8c4f231) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev    #1226      +/-   ##
==========================================
- Coverage   82.66%   82.65%   -0.01%     
==========================================
  Files         157      157              
  Lines       20180    20180              
  Branches     7626     7626              
==========================================
- Hits        16681    16679       -2     
- Misses       2878     2880       +2     
  Partials      621      621              

Flag	Coverage Δ
alpine317	72.34% <ø> (ø)
centos7	74.58% <ø> (ø)
fedora37	72.30% <ø> (-0.05%)	⬇️
macos-11	61.29% <ø> (ø)
macos-12	61.34% <ø> (ø)
macos-ventura	61.32% <ø> (+<0.01%)	⬆️
mingw32	70.21% <ø> (-0.04%)	⬇️
mingw64	70.25% <ø> (-0.02%)	⬇️
npcap	83.20% <ø> (-0.05%)	⬇️
ubuntu1804	74.97% <ø> (ø)
ubuntu2004	73.14% <ø> (+<0.01%)	⬆️
ubuntu2204	72.15% <ø> (-0.05%)	⬇️
ubuntu2204-icpx	59.19% <ø> (ø)
unittest	82.65% <ø> (-0.01%)	⬇️
windows-2019	83.24% <ø> (-0.02%)	⬇️
windows-2022	83.25% <ø> (-0.02%)	⬇️
winpcap	83.21% <ø> (-0.02%)	⬇️
zstd	73.73% <ø> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

[seladb]

@clementperon Packet++Test and Pcap++Test also use getopt_long and they don't fail with this change. Maybe getopt / getop_long support was added since VS 2019 so this dependency isn't needed anymore? 🤔

[clementperon]

@clementperon Packet++Test and Pcap++Test also use getopt_long and they don't fail with this change. Maybe getopt / getop_long support was added since VS 2019 so this dependency isn't needed anymore? 🤔

No it's because we
add_subdirectory(Examples)
before
add_subdirectory(Tests)

So the GetOpt is present for Tests...

[seladb]

@clementperon Packet++Test and Pcap++Test also use getopt_long and they don't fail with this change. Maybe getopt / getop_long support was added since VS 2019 so this dependency isn't needed anymore? 🤔

No it's because we add_subdirectory(Examples) before add_subdirectory(Tests)

So the GetOpt is present for Tests...

So if users don't want to build the examples they won't be to build the test either?

[clementperon]

@clementperon Packet++Test and Pcap++Test also use getopt_long and they don't fail with this change. Maybe getopt / getop_long support was added since VS 2019 so this dependency isn't needed anymore? 🤔

No it's because we add_subdirectory(Examples) before add_subdirectory(Tests)
So the GetOpt is present for Tests...

So if users don't want to build the examples they won't be to build the test either?

Yes so not acceptable as it.

[seladb]

@clementperon Packet++Test and Pcap++Test also use getopt_long and they don't fail with this change. Maybe getopt / getop_long support was added since VS 2019 so this dependency isn't needed anymore? 🤔

No it's because we add_subdirectory(Examples) before add_subdirectory(Tests)
So the GetOpt is present for Tests...

So if users don't want to build the examples they won't be to build the test either?

Yes so not acceptable as it.

Yes, I think it's not a good idea to move GetOpt to Examples if the tests also use them...