Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the error in detecting the loopback device. #1221

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Conversation

liu0hy
Copy link
Contributor

@liu0hy liu0hy commented Oct 20, 2023

No description provided.

@liu0hy liu0hy requested a review from seladb as a code owner October 20, 2023 01:22
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #1221 (bd1b415) into dev (b19d842) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev    #1221      +/-   ##
==========================================
- Coverage   82.65%   82.64%   -0.02%     
==========================================
  Files         157      157              
  Lines       20181    20180       -1     
  Branches     7626     7626              
==========================================
- Hits        16681    16677       -4     
- Misses       2879     2885       +6     
+ Partials      621      618       -3     
Flag Coverage Δ
alpine317 72.34% <ø> (-0.01%) ⬇️
centos7 74.58% <ø> (-0.01%) ⬇️
fedora37 72.30% <ø> (-0.05%) ⬇️
macos-11 61.29% <ø> (-0.01%) ⬇️
macos-12 61.34% <ø> (-0.01%) ⬇️
macos-ventura 61.31% <ø> (-0.01%) ⬇️
mingw32 70.23% <ø> (-0.02%) ⬇️
mingw64 70.23% <ø> (-0.02%) ⬇️
npcap 83.18% <ø> (-0.06%) ⬇️
ubuntu1804 75.01% <ø> (+0.03%) ⬆️
ubuntu2004 73.08% <ø> (-0.05%) ⬇️
ubuntu2204 72.15% <ø> (-0.01%) ⬇️
ubuntu2204-icpx 59.18% <ø> (-0.01%) ⬇️
unittest 82.64% <ø> (-0.02%) ⬇️
windows-2019 83.22% <ø> (-0.03%) ⬇️
windows-2022 83.23% <ø> (-0.03%) ⬇️
winpcap 83.21% <ø> (-0.02%) ⬇️
zstd 73.69% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
Pcap++/src/PcapLiveDevice.cpp 77.98% <ø> (-0.87%) ⬇️

... and 2 files with indirect coverage changes

@seladb seladb merged commit 8c4f231 into seladb:dev Oct 20, 2023
35 checks passed
@seladb
Copy link
Owner

seladb commented Oct 20, 2023

Thank you @liu0hy for fixing this bug, much appreciated! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants