Skip to content

Commit

Permalink
Added explicit defaulted public destructors to device lists.
Browse files Browse the repository at this point in the history
  • Loading branch information
Dimi1010 committed Nov 27, 2024
1 parent 9ad70af commit 871cca7
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 0 deletions.
2 changes: 2 additions & 0 deletions Pcap++/header/DpdkDeviceList.h
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,8 @@ namespace pcpp
static int dpdkWorkerThreadStart(void* ptr);

public:
~DpdkDeviceList() = default;

/**
* As DpdkDeviceList is a singleton, this is the static getter to retrieve its instance. Note that if the static
* method initDpdk() was not called or returned false this instance won't be initialized and DpdkDevices won't
Expand Down
1 change: 1 addition & 0 deletions Pcap++/header/PcapLiveDeviceList.h
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ namespace pcpp
PcapLiveDeviceList(PcapLiveDeviceList&&) noexcept = delete;
PcapLiveDeviceList& operator=(const PcapLiveDeviceList&) = delete;
PcapLiveDeviceList& operator=(PcapLiveDeviceList&&) noexcept = delete;
~PcapLiveDeviceList() = default;

/**
* The access method to the singleton
Expand Down
1 change: 1 addition & 0 deletions Pcap++/header/PcapRemoteDeviceList.h
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ namespace pcpp
PcapRemoteDeviceList(PcapRemoteDeviceList&&) noexcept = delete;
PcapRemoteDeviceList& operator=(const PcapRemoteDeviceList&) = delete;
PcapRemoteDeviceList& operator=(PcapRemoteDeviceList&&) noexcept = delete;
~PcapRemoteDeviceList() = default;

/**
* A static method for creating a PcapRemoteDeviceList instance for a certain remote machine. This methods
Expand Down
1 change: 1 addition & 0 deletions Pcap++/header/PfRingDeviceList.h
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ namespace pcpp
PfRingDeviceList(PfRingDeviceList&&) noexcept = delete;
PfRingDeviceList& operator=(const PfRingDeviceList&) = delete;
PfRingDeviceList& operator=(PfRingDeviceList&&) noexcept = delete;
~PfRingDeviceList() = default;

/**
* A static method that returns the singleton object for PfRingDeviceList
Expand Down

0 comments on commit 871cca7

Please sign in to comment.