Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(logger) : Deprecate the Discord, Slack structures, and send logs via a Handler. #33

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

seipan
Copy link
Owner

@seipan seipan commented Dec 16, 2023

resolve : #30
Originally, we had structures named Discord and Slack, each containing a webhook URL, and used these structures to switch between slack and discord types to send logs. However, this approach is cumbersome from the perspective of custom handlers, so we will be doing a comprehensive refactoring. I consider this to be a long-term task, and we will take our time to ensure the previous functionalities are preserved.

Copy link

codecov bot commented Dec 16, 2023

Codecov Report

Attention: 59 lines in your changes are missing coverage. Please review.

Comparison is base (8440a71) 43.14% compared to head (81110a4) 43.94%.
Report is 2 commits behind head on main.

Files Patch % Lines
logger.go 37.50% 25 Missing ⚠️
option.go 45.94% 20 Missing ⚠️
webhook.go 53.33% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
+ Coverage   43.14%   43.94%   +0.80%     
==========================================
  Files           5        4       -1     
  Lines         394      314      -80     
==========================================
- Hits          170      138      -32     
+ Misses        222      174      -48     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the slack label Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat : Custom Handler
1 participant