Skip to content

Commit

Permalink
CurrencyConvert: Updated the Google Finance URL
Browse files Browse the repository at this point in the history
Google has Moved the Finance API to a new URL and so its now updated in the package also.
  • Loading branch information
RodWizard committed Sep 14, 2017
1 parent f2a5336 commit 2030f64
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
5 changes: 2 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,9 @@ A Simple Extended helper functions for Laravel. Supports v5.3+ (also **v5.5**).
> **Open For Suggestions** on more Tricks/Helper Functions that Laravel does not provides by default. **Give your suggestions using *Issue* Tracking feature of GitHub** and I will do my best to add them.
## Upgrade Guide
### To v2.1.0
### To v2.3.1
- Update your published `config\trickster.php` according to the project's updated `config\trickster.php`.
- Remove the Usage of Twitter Analytics as it's support has now been discontinued and therefore, it has been removed from Trickster also.

- **Update your Google Finance API URL**, check the [config/trickster.php](src/config/trickster.php) configuration file.
## Trickster’s Tricks
1. Truncator
2. Email Validator
Expand Down
2 changes: 1 addition & 1 deletion src/Trickster.php
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ class Trickster
* Get vimeo video data from api
* @var string
*/
protected $_googleFinanceApi = 'https://www.google.com/finance/converter?a=%d&from=%s&to=%s';
protected $_googleFinanceApi = 'https://finance.google.com/finance/converter?a=%d&from=%s&to=%s';

/**
* Display a listing of the resource.
Expand Down
2 changes: 1 addition & 1 deletion src/config/trickster.php
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@
'urlShorten' => 'https://www.googleapis.com/urlshortener/v1/url',
'suggest' => 'https://suggestqueries.google.com/complete/search?output=firefox&client=firefox&hl=en-US&q=%s',
'youtube' => 'https://gdata.youtube.com/feeds/api/videos/%s?v=2&alt=json',
'finance' => 'https://www.google.com/finance/converter?a=%d&from=%s&to=%s'
'finance' => 'https://finance.google.com/finance/converter?a=%d&from=%s&to=%s'
),
'wikipedia' => array(
'askWiki' => 'https://en.wikipedia.org/w/api.php?action=opensearch&search=%s&format=xml&limit=1'
Expand Down

0 comments on commit 2030f64

Please sign in to comment.