Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LDAP: add/modifydn #4652

Merged
merged 1 commit into from
Feb 3, 2025
Merged

LDAP: add/modifydn #4652

merged 1 commit into from
Feb 3, 2025

Conversation

gpotter2
Copy link
Member

@gpotter2 gpotter2 commented Feb 3, 2025

  • LDAP: implement modifydn
  • LDAP_Client: add add and modifydn functions

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 44.00000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 81.63%. Comparing base (f998c63) to head (5490a1c).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
scapy/layers/ldap.py 44.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4652      +/-   ##
==========================================
+ Coverage   81.42%   81.63%   +0.21%     
==========================================
  Files         359      359              
  Lines       86237    86266      +29     
==========================================
+ Hits        70215    70425     +210     
+ Misses      16022    15841     -181     
Files with missing lines Coverage Δ
scapy/layers/ldap.py 67.58% <44.00%> (-0.81%) ⬇️

... and 26 files with indirect coverage changes

@gpotter2 gpotter2 merged commit b4dbb19 into secdev:master Feb 3, 2025
24 checks passed
@gpotter2 gpotter2 deleted the ldapfixes branch February 3, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant