Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dead link in extending.rst #2064

Merged
merged 3 commits into from
Jun 6, 2019
Merged

Conversation

danielmichaels
Copy link
Contributor

brief description what this PR will do, e.g. fixes broken dissection of XXX

Improve Documentation

Reading over the docs, the link to Wifitap is dead. I found Wifitap's GitHub repo and replaced the link with it.

Wifitap project maintainers website replaced with GitHub repo link.
@codecov
Copy link

codecov bot commented Jun 4, 2019

Codecov Report

Merging #2064 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2064      +/-   ##
==========================================
- Coverage   86.34%   86.33%   -0.01%     
==========================================
  Files         197      197              
  Lines       44603    44603              
==========================================
- Hits        38514    38510       -4     
- Misses       6089     6093       +4
Impacted Files Coverage Δ
scapy/automaton.py 81.81% <0%> (-0.56%) ⬇️
scapy/layers/inet6.py 87.99% <0%> (-0.3%) ⬇️
scapy/sendrecv.py 85.37% <0%> (+0.16%) ⬆️
scapy/asn1/ber.py 83.09% <0%> (+0.28%) ⬆️
scapy/layers/tls/record.py 92.1% <0%> (+0.87%) ⬆️

@gpotter2
Copy link
Member

gpotter2 commented Jun 4, 2019

The repo you've provided looks pretty dead :/
It seems that GDSSecurity/wifitap#1 actually makes it work with recent Scapy versions, but I doubt it really does with master :/

I'll ask there if the project is dead. If it is, it might be a better idea to remove the link

@p-l-
Copy link
Member

p-l- commented Jun 5, 2019

We are keeping that link for historical & sentimental reasons. I think we should just add a note to state that Wifitap is no longer updated... but I'd like to keep the current link.

Do you want it to read something like this?
@danielmichaels
Copy link
Contributor Author

danielmichaels commented Jun 5, 2019

We are keeping that link for historical & sentimental reasons. I think we should just add a note to state that Wifitap is no longer updated... but I'd like to keep the current link.

@p-l-, does a change like this suit?

doc/scapy/extending.rst Outdated Show resolved Hide resolved
@gpotter2 gpotter2 merged commit d3ad5be into secdev:master Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants