Skip to content

Commit

Permalink
Fix translation for Search and add test (SEA-1390)
Browse files Browse the repository at this point in the history
  • Loading branch information
cyrillkuettel committed Jul 18, 2024
1 parent 9b07240 commit da3c1fb
Show file tree
Hide file tree
Showing 5 changed files with 23 additions and 7 deletions.
3 changes: 2 additions & 1 deletion src/privatim/layouts/macros.pt
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,8 @@
<form enctype="multipart/form-data" method="POST" action="${action}" novalidate
class="col-12 col-lg-auto mb-3 mb-lg-0 me-lg-3 d-flex align-items-center" id="search">
<input type="hidden" name="csrf_token" value="${layout.csrf_token()}"/>
<input type="text" name="term" autocomplete="off" class="form-control" placeholder="Search..."/>
<input type="text" name="term" autocomplete="off" class="form-control" placeholder="Search..."
i18n:attributes="placeholder"/>
<button type="submit" class="btn btn-secondary" id="search-button"><i class="fa fa-search"></i></button>
</form>
</div>
Expand Down
6 changes: 5 additions & 1 deletion src/privatim/locale/de/LC_MESSAGES/privatim.po
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
msgid ""
msgstr ""
"Project-Id-Version: PACKAGE 1.0\n"
"POT-Creation-Date: 2024-07-10 10:22+0200\n"
"POT-Creation-Date: 2024-07-18 15:05+0200\n"
"PO-Revision-Date: 2024-05-21 21:20+0200\n"
"Last-Translator: cyrill <[email protected]>\n"
"Language-Team: German <[email protected]>\n"
Expand Down Expand Up @@ -53,6 +53,10 @@ msgstr "Nachricht"
msgid "Answer"
msgstr "Antworten"

#: src/privatim/layouts/macros.pt
msgid "Search..."
msgstr "Suchen..."

#: src/privatim/layouts/navbar.pt src/privatim/views/activities.py
msgid "Activities"
msgstr "Aktivitäten"
Expand Down
6 changes: 5 additions & 1 deletion src/privatim/locale/fr/LC_MESSAGES/privatim.po
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
msgid ""
msgstr ""
"Project-Id-Version: PACKAGE 1.0\n"
"POT-Creation-Date: 2024-07-10 10:22+0200\n"
"POT-Creation-Date: 2024-07-18 15:05+0200\n"
"PO-Revision-Date: 2024-04-11 15:53+0200\n"
"Last-Translator: cyrill <[email protected]>\n"
"Language-Team: French <[email protected]>\n"
Expand Down Expand Up @@ -50,6 +50,10 @@ msgstr "Message"
msgid "Answer"
msgstr "Répondre"

#: src/privatim/layouts/macros.pt
msgid "Search..."
msgstr "Rechercher..."

#: src/privatim/layouts/navbar.pt src/privatim/views/activities.py
msgid "Activities"
msgstr "Activités"
Expand Down
6 changes: 5 additions & 1 deletion src/privatim/locale/privatim.pot
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
msgid ""
msgstr ""
"Project-Id-Version: PACKAGE 1.0\n"
"POT-Creation-Date: 2024-07-10 10:22+0200\n"
"POT-Creation-Date: 2024-07-18 15:05+0200\n"
"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
"Language-Team: LANGUAGE <[email protected]>\n"
Expand Down Expand Up @@ -50,6 +50,10 @@ msgstr ""
msgid "Answer"
msgstr ""

#: ./src/privatim/layouts/macros.pt
msgid "Search..."
msgstr ""

#: ./src/privatim/layouts/navbar.pt ./src/privatim/views/activities.py
msgid "Activities"
msgstr ""
Expand Down
9 changes: 6 additions & 3 deletions tests/views/client/test_views_homepage.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
def test_filter(client):

def test_translation_navbar(client):
client.login_admin()

page = client.get('/activities')
form = page.forms['filter_activities']
breakpoint()
form = page.pyquery('form#search')[0]
input_search = form[1]
assert input_search.get('placeholder') == 'Suchen...'

0 comments on commit da3c1fb

Please sign in to comment.