Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time Dependent Arma Markov #1

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

RobertASmith
Copy link

Hi Sam,

I needed to run a time dependent Markov model- so adapted your code from Aramamarkov.

I have included the C++ code and some tests on the code which I have used in my own package here: https://github.com/RobertASmith/darkpeak, hoping that this may be useful to others through SpeedyMarkov.

I have not included Roxygen comments etc as I am not sure how you want to refer to this function (if at all). Still fairly new to packages in R so not sure how best to do this.

Cheers,

Rob

@seabbs
Copy link
Owner

seabbs commented Nov 23, 2020

Hi Robert,

This looks really nice - thanks for contributing back! Unfortunately I am a bit stretched at the moment due to the day job working on Covid but will get on this asap.

Had a look at your package and it looks great.

Not sure what the direction of travel is for SpeedyMarkov (i.e if it should become something that gets used or if it should be more of an example). Be interested if you have any thoughts.

Sam

@RobertASmith
Copy link
Author

RobertASmith commented Nov 23, 2020

Cheers for looking at this, didn't expect such a quick response! I'm starting a COVID project on Monday, so trying to smash through jobs I've put off.

Would be good to discuss health economics stats programming when things quieten down. Been working with a colleague to build some useful tools for HTA in R, but we would like to get a group together and apply for funding to validate packages & provide a 'stamp of approval' for the industry.

Not sure on SpeedyMarkov in particular, there certainly needs to be a repo for useful functions for health economic evaluation - if its a case of building on SpeedyMarkov or integrating it into another package then either seems fine. If it stays then you need a better hexSticker :) Maybe this:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants