feature(views-with-tablets): enable testing materialized views with tablets #9615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmitros
force-pushed
the
forbid-tablet-mv
branch
from
0beb533 to
2d59969
Compare
|
Looks like yaml tests aren't using the default configurations, fixed in rebase |
…ablets Materialized views are currently not allowed in tablet keyspaces, due to some pending issues. However, they can be enabled using the "views-with-tablets" experimental feature. While improving views with tablets, we should make sure that the existing tests keep passing, so we should run materialized view (and index) tests with tablets using the experimental feature. The feature doesn't affect tests ran on vnodes. For tablets, the tests would fail without the feature due to unsupported configuration. Considering that, we should enable the feature by default for all tests (with a special consideration to upgrade tests). The change includes: * modifying the default experimental_features in defaults/test_default.yaml * updating upgrade tests - for upgrades, the first version with this experimental feature will be 2025.1, so the upgrade tests are updated to remove this feature from the defaults and to set it when upgrading to 2025.1 or higher. When testing upgrades to future versions, we'll need to keep the experimental_feature also for base version, with an exception for sequential upgrades, (currently we only have 2021.1->2022.1->2023.1 test in test_custom_profile_sequential_rolling_upgrade) where the base version of the sequence might not have this experimental feature, so we'll need to adjust it accordingly.
wmitros
force-pushed
the
forbid-tablet-mv
branch
from
2d59969 to
8380a4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Materialized views are currently not allowed in tablet keyspaces, due to some pending issues. However, they can be enabled using the "views-with-tablets" experimental feature.
While improving views with tablets, we should make sure that the existing tests keep passing, so we should run materialized view (and index) tests with tablets using the experimental feature.
The feature doesn't affect tests ran on vnodes. For tablets, the tests would fail without the feature due to unsupported configuration.
Considering that, we should enable the feature by default for all tests (with a special consideration to upgrade tests).
The change includes: