Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(manager): update version of Manager in upgrade test #9581

Merged

Conversation

mikliapko
Copy link
Contributor

@mikliapko mikliapko commented Dec 18, 2024

Since we are about to release Manager 3.4.1, updating manager_version to 3.4.0 (the latest patch release) for the upgrade job that verifies upgrades from the latest patch release (ubuntu24-manager-upgrade).

The jobs that check upgrade from minor releases (3.3.*) left unchanged.

Testing

  • Upgrade from 3.4.0 to the latest Manager from master

PR pre-checks (self review)

  • I added the relevant backport labels
  • I didn't leave commented-out/debugging code

Since we are about to release Manager 3.4.1, updating manager_version
to 3.4.0 (the latest patch release) for the upgrade job that verifies
upgrades from the latest patch release (ubuntu24-manager-upgrade).
@mikliapko mikliapko added the backport/none Backport is not required label Dec 18, 2024
@mikliapko mikliapko self-assigned this Dec 18, 2024
@mikliapko mikliapko marked this pull request as ready for review December 19, 2024 14:43
@mikliapko mikliapko requested a review from rayakurl as a code owner December 19, 2024 14:43
@mikliapko mikliapko requested review from karol-kokoszka, Michal-Leszczynski and a team and removed request for rayakurl December 19, 2024 14:43
@soyacz
Copy link
Contributor

soyacz commented Dec 19, 2024

@fruch PIE checks failed on

00:06:10.476  sdcm/provision/scylla_yaml/scylla_yaml.py:44:5: PIE794 Class field `listen_interface` is defined multiple times
00:06:10.476     |
00:06:10.476  42 |     cluster_name: str = None  # ""
00:06:10.476  43 |     listen_address: str = None  # "localhost"
00:06:10.476  44 |     listen_interface: str = None  # "eth0"
00:06:10.476     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ PIE794
00:06:10.476  45 |     listen_interface_prefer_ipv6: bool = None  # False
00:06:10.476  46 |     commitlog_directory: str = None  # ""
00:06:10.476     |
00:06:10.476     = help: Remove duplicate field definition for `listen_interface`

which is strange as it's not duplicated... checker bug?

@fruch
Copy link
Contributor

fruch commented Dec 19, 2024

@fruch PIE checks failed on

00:06:10.476  sdcm/provision/scylla_yaml/scylla_yaml.py:44:5: PIE794 Class field `listen_interface` is defined multiple times
00:06:10.476     |
00:06:10.476  42 |     cluster_name: str = None  # ""
00:06:10.476  43 |     listen_address: str = None  # "localhost"
00:06:10.476  44 |     listen_interface: str = None  # "eth0"
00:06:10.476     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ PIE794
00:06:10.476  45 |     listen_interface_prefer_ipv6: bool = None  # False
00:06:10.476  46 |     commitlog_directory: str = None  # ""
00:06:10.476     |
00:06:10.476     = help: Remove duplicate field definition for `listen_interface`

which is strange as it's not duplicated... checker bug?

Could be, I'll need to take a closer look at it

@mikliapko
Copy link
Contributor Author

@scylladb/qa-maintainers @karol-kokoszka @Michal-Leszczynski
Could you please guys take a look?

Copy link
Contributor

@soyacz soyacz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@vponomaryov vponomaryov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vponomaryov vponomaryov merged commit ac2ac49 into scylladb:master Jan 24, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/none Backport is not required promoted-to-master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants