Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split images and add CI script to run e2e in-cluster #31

Merged
merged 4 commits into from
Dec 6, 2023
Merged

Split images and add CI script to run e2e in-cluster #31

merged 4 commits into from
Dec 6, 2023

Conversation

tnozicka
Copy link
Contributor

@tnozicka tnozicka commented Dec 4, 2023 •
edited
Loading

This PR:

  • splits the runtime and e2e tests image
  • embeds kubectl into the e2e tests image where it is required (and was previously; this removes the mount hack)
  • adds ci script to run e2e's on remote cluster (for Prow)

Requires
Preview Give feedback
  1. Make sure xfs-disk-setup lands on the same nodes as local-csi-driver k8s-local-volume-provisioner#33
    kind/cleanup priority/important-soon size/XS
  2. Make xfs-disk-setup DaemonSet reentrant k8s-local-volume-provisioner#35
    kind/cleanup priority/important-soon size/XS
  3. Fix e2e to use in-cluster config k8s-local-volume-provisioner#37
    kind/cleanup priority/important-soon size/S

@tnozicka tnozicka added kind/machinery Categorizes issue or PR as related to Makefile, scripts or similar changes. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Dec 4, 2023
@scylla-operator-bot scylla-operator-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 4, 2023
@tnozicka tnozicka added this to the v0.3 milestone Dec 4, 2023
@tnozicka tnozicka force-pushed the prow branch 2 times, most recently from 17f9290 to 38fa081 Compare December 5, 2023 10:07
@scylla-operator-bot scylla-operator-bot bot added the area/dependency Issues or PRs related to dependency changes label Dec 5, 2023
@scylla-operator-bot scylla-operator-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@scylla-operator-bot scylla-operator-bot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2023
@tnozicka
Copy link
Contributor Author

tnozicka commented Dec 5, 2023

/test all

@tnozicka tnozicka force-pushed the prow branch 3 times, most recently from c388672 to 53e49ed Compare December 5, 2023 15:22
@tnozicka
Copy link
Contributor Author

tnozicka commented Dec 5, 2023

/retest

@tnozicka tnozicka changed the title [WIP] Split images and add CI script to run e2e in-cluster Split images and add CI script to run e2e in-cluster Dec 6, 2023
@scylla-operator-bot scylla-operator-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 6, 2023
@tnozicka tnozicka requested a review from zimnx December 6, 2023 07:22
@tnozicka
Copy link
Contributor Author

tnozicka commented Dec 6, 2023

@zimnx this is ready to be reviewed.
(Let Tide merge it when you're tagging it. I'll switch the required jobs on the repo when it has the tags.)

zimnx
zimnx reviewed Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@zimnx zimnx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment, rest lgtm

hack/.ci/run-e2e-gke.sh
kubectl create namespace e2e --dry-run=client -o yaml | kubectl_create -f -
kubectl create clusterrolebinding e2e --clusterrole=cluster-admin --serviceaccount=e2e:default --dry-run=client -o yaml | kubectl_create -f -

timeout -v 10m ./hack/ci-deploy.sh "${E2E_IMAGE}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets increase log level to 4 of the driver DS, it will help us with debugging when we need it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kind of wanted it to be rather adjusted on demand + the way it was done was racy a bit but I can bring it back.

Copy link
Contributor Author

@tnozicka tnozicka Dec 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added, (with wait)

@zimnx
Copy link
Collaborator

zimnx commented Dec 6, 2023

Thanks!
/lgtm

@scylla-operator-bot scylla-operator-bot bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2023
@scylla-operator-bot scylla-operator-bot bot merged commit d464bc5 into scylladb:master Dec 6, 2023
@tnozicka tnozicka deleted the prow branch December 6, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimnx zimnx zimnx left review comments

Assignees

@zimnx zimnx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes kind/machinery Categorizes issue or PR as related to Makefile, scripts or similar changes. lgtm Indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v0.3
Development

Successfully merging this pull request may close these issues.
2 participants
@tnozicka @zimnx