Update golangci-lint in Makefile and CI and turn it on in CI #147
dkropachevAnnotations
10 errors and 11 warnings
|
Build:
migrate/migrate_test.go#L103
Error return value of `f.WriteFile` is not checked (errcheck)
|
|
Build:
migrate/migrate_test.go#L267
Error return value of `f.WriteFile` is not checked (errcheck)
|
|
Build:
example_test.go#L37
Error return value of `session.ExecStmt` is not checked (errcheck)
|
|
Build:
queryx_bench_test.go#L17
Error return value of `gocqlx.CompileNamedQuery` is not checked (errcheck)
|
|
Build:
migrate/migrate.go#L131
use of `fmt.Println` forbidden by pattern `^(fmt\.Print(|f|ln)|print|println)$` (forbidigo)
|
|
Build:
qb/batch_test.go#L67
octalLiteral: use new octal literal style, 0o5 (gocritic)
|
|
Build:
qb/delete_test.go#L72
octalLiteral: use new octal literal style, 0o5 (gocritic)
|
|
Build:
qb/insert_test.go#L70
octalLiteral: use new octal literal style, 0o5 (gocritic)
|
|
Build:
cmd/schemagen/map_types.go#L79
assignOp: replace `typeStr = typeStr + "\t}"` with `typeStr += "\t}"` (gocritic)
|
|
Build:
cmd/schemagen/map_types.go#L99
wrapperFunc: use strings.ReplaceAll method in `strings.Replace(collectionType, "(", "<", -1)` (gocritic)
|
|
Build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-go@v3, actions/cache@v3, golangci/golangci-lint-action@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Build:
migrate/example/cql/embed.go#L7
package-comments: should have a package comment (revive)
|
|
Build:
batchx.go#L7
exported: exported type Batch should have comment or be unexported (revive)
|
|
Build:
transformer.go#L24
unused-parameter: parameter 'name' seems to be unused, consider removing or renaming it as _ (revive)
|
|
Build:
migrate/example/example_test.go#L40
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
Build:
cmd/schemagen/schemagen_test.go#L108
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
|
|
Build:
cmd/schemagen/camelize.go#L5
package-comments: should have a package comment (revive)
|
|
Build:
migrate/migrate_test.go#L19
dot-imports: should not use dot imports (revive)
|
|
Build:
migrate/migrate_test.go#L171
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
Build:
migrate/migrate_test.go#L174
increment-decrement: should replace beforeCalled += 1 with beforeCalled++ (revive)
|
|
Build:
migrate/migrate_test.go#L176
increment-decrement: should replace afterCalled += 1 with afterCalled++ (revive)
|