-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for hostname verification #31
Conversation
Few checks executed to verify the change:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
small nitpick: Do I understand correctly that this option only pertains to the java driver? It seems that c-s can also use thrift client. We probably don't care about that part though. If you want you can modify option description to something like SSL: enable hostname verification in Java Driver
The change adds ability to execute cassandra-stress with hostname verification, when client TLS/SSL encryption is enabled. The verification is programmatically configured/enabled using the RemoteEndpointAwareJdkSSLOptions class provded by the driver. Fixes: scylladb#22
2bf1d18
to
512236b
Compare
Added that info to the option description |
Main reason for version change: Using cassandra-stress 3.17 to mittigate - Switch to ReplicaOrdering.RANDOM for select LBPs [32](scylladb/cassandra-stress#32) Other Noticable Changes since the last version used in SCT: - Add support for hostname verification [31](scylladb/cassandra-stress#31) - Print thread dump on specific signals [27](scylladb/cassandra-stress#27) - Replace uninterruptible wait [26](scylladb/cassandra-stress#26) - Make it use DCAwareRoundRobinPolicy unless rack is provided [21](scylladb/cassandra-stress#21) - feature(docker): adding support for dependabot [19](scylladb/cassandra-stress#19) Signed-off-by: Dusan Malusev <[email protected]>
Main reason for version change: Using cassandra-stress 3.17 to mittigate - Switch to ReplicaOrdering.RANDOM for select LBPs [32](scylladb/cassandra-stress#32) Other Noticable Changes since the last version used in SCT: - Add support for hostname verification [31](scylladb/cassandra-stress#31) - Print thread dump on specific signals [27](scylladb/cassandra-stress#27) - Replace uninterruptible wait [26](scylladb/cassandra-stress#26) - Make it use DCAwareRoundRobinPolicy unless rack is provided [21](scylladb/cassandra-stress#21) - feature(docker): adding support for dependabot [19](scylladb/cassandra-stress#19) Signed-off-by: Dusan Malusev <[email protected]>
Main reason for version change: Using cassandra-stress 3.17 to mittigate - Switch to ReplicaOrdering.RANDOM for select LBPs [32](scylladb/cassandra-stress#32) Other Noticable Changes since the last version used in SCT: - Add support for hostname verification [31](scylladb/cassandra-stress#31) - Print thread dump on specific signals [27](scylladb/cassandra-stress#27) - Replace uninterruptible wait [26](scylladb/cassandra-stress#26) - Make it use DCAwareRoundRobinPolicy unless rack is provided [21](scylladb/cassandra-stress#21) - feature(docker): adding support for dependabot [19](scylladb/cassandra-stress#19) Signed-off-by: Dusan Malusev <[email protected]>
Main reason for version change: Using cassandra-stress 3.17 to mittigate - Switch to ReplicaOrdering.RANDOM for select LBPs [32](scylladb/cassandra-stress#32) Other Noticable Changes since the last version used in SCT: - Add support for hostname verification [31](scylladb/cassandra-stress#31) - Print thread dump on specific signals [27](scylladb/cassandra-stress#27) - Replace uninterruptible wait [26](scylladb/cassandra-stress#26) - Make it use DCAwareRoundRobinPolicy unless rack is provided [21](scylladb/cassandra-stress#21) - feature(docker): adding support for dependabot [19](scylladb/cassandra-stress#19) Signed-off-by: Dusan Malusev <[email protected]>
Main reason for version change: Using cassandra-stress 3.17 to mittigate - Switch to ReplicaOrdering.RANDOM for select LBPs [32](scylladb/cassandra-stress#32) Other Noticable Changes since the last version used in SCT: - Add support for hostname verification [31](scylladb/cassandra-stress#31) - Print thread dump on specific signals [27](scylladb/cassandra-stress#27) - Replace uninterruptible wait [26](scylladb/cassandra-stress#26) - Make it use DCAwareRoundRobinPolicy unless rack is provided [21](scylladb/cassandra-stress#21) - feature(docker): adding support for dependabot [19](scylladb/cassandra-stress#19) Signed-off-by: Dusan Malusev <[email protected]>
Main reason for version change: Using cassandra-stress 3.17 to mittigate - Switch to ReplicaOrdering.RANDOM for select LBPs [32](scylladb/cassandra-stress#32) Other Noticable Changes since the last version used in SCT: - Add support for hostname verification [31](scylladb/cassandra-stress#31) - Print thread dump on specific signals [27](scylladb/cassandra-stress#27) - Replace uninterruptible wait [26](scylladb/cassandra-stress#26) - Make it use DCAwareRoundRobinPolicy unless rack is provided [21](scylladb/cassandra-stress#21) - feature(docker): adding support for dependabot [19](scylladb/cassandra-stress#19) Signed-off-by: Dusan Malusev <[email protected]> (cherry picked from commit 02997a6) # Conflicts: # defaults/docker_images/cassandra-stress/values_cassandra-stress.yaml
Main reason for version change: Using cassandra-stress 3.17 to mittigate - Switch to ReplicaOrdering.RANDOM for select LBPs [32](scylladb/cassandra-stress#32) Other Noticable Changes since the last version used in SCT: - Add support for hostname verification [31](scylladb/cassandra-stress#31) - Print thread dump on specific signals [27](scylladb/cassandra-stress#27) - Replace uninterruptible wait [26](scylladb/cassandra-stress#26) - Make it use DCAwareRoundRobinPolicy unless rack is provided [21](scylladb/cassandra-stress#21) - feature(docker): adding support for dependabot [19](scylladb/cassandra-stress#19) Signed-off-by: Dusan Malusev <[email protected]> (cherry picked from commit 02997a6) # Conflicts: # defaults/docker_images/cassandra-stress/values_cassandra-stress.yaml
Main reason for version change: Using cassandra-stress 3.17 to mittigate - Switch to ReplicaOrdering.RANDOM for select LBPs [32](scylladb/cassandra-stress#32) Other Noticable Changes since the last version used in SCT: - Add support for hostname verification [31](scylladb/cassandra-stress#31) - Print thread dump on specific signals [27](scylladb/cassandra-stress#27) - Replace uninterruptible wait [26](scylladb/cassandra-stress#26) - Make it use DCAwareRoundRobinPolicy unless rack is provided [21](scylladb/cassandra-stress#21) - feature(docker): adding support for dependabot [19](scylladb/cassandra-stress#19) Signed-off-by: Dusan Malusev <[email protected]> (cherry picked from commit 02997a6)
Main reason for version change: Using cassandra-stress 3.17 to mittigate - Switch to ReplicaOrdering.RANDOM for select LBPs [32](scylladb/cassandra-stress#32) Other Noticable Changes since the last version used in SCT: - Add support for hostname verification [31](scylladb/cassandra-stress#31) - Print thread dump on specific signals [27](scylladb/cassandra-stress#27) - Replace uninterruptible wait [26](scylladb/cassandra-stress#26) - Make it use DCAwareRoundRobinPolicy unless rack is provided [21](scylladb/cassandra-stress#21) - feature(docker): adding support for dependabot [19](scylladb/cassandra-stress#19) Signed-off-by: Dusan Malusev <[email protected]> (cherry picked from commit 02997a6) # Conflicts: # defaults/docker_images/cassandra-stress/values_cassandra-stress.yaml
Main reason for version change: Using cassandra-stress 3.17 to mittigate - Switch to ReplicaOrdering.RANDOM for select LBPs [32](scylladb/cassandra-stress#32) Other Noticable Changes since the last version used in SCT: - Add support for hostname verification [31](scylladb/cassandra-stress#31) - Print thread dump on specific signals [27](scylladb/cassandra-stress#27) - Replace uninterruptible wait [26](scylladb/cassandra-stress#26) - Make it use DCAwareRoundRobinPolicy unless rack is provided [21](scylladb/cassandra-stress#21) - feature(docker): adding support for dependabot [19](scylladb/cassandra-stress#19) Signed-off-by: Dusan Malusev <[email protected]> (cherry picked from commit 02997a6)
Main reason for version change: Using cassandra-stress 3.17 to mittigate - Switch to ReplicaOrdering.RANDOM for select LBPs [32](scylladb/cassandra-stress#32) Other Noticable Changes since the last version used in SCT: - Add support for hostname verification [31](scylladb/cassandra-stress#31) - Print thread dump on specific signals [27](scylladb/cassandra-stress#27) - Replace uninterruptible wait [26](scylladb/cassandra-stress#26) - Make it use DCAwareRoundRobinPolicy unless rack is provided [21](scylladb/cassandra-stress#21) - feature(docker): adding support for dependabot [19](scylladb/cassandra-stress#19) Signed-off-by: Dusan Malusev <[email protected]> (cherry picked from commit 02997a6)
Main reason for version change: Using cassandra-stress 3.17 to mittigate - Switch to ReplicaOrdering.RANDOM for select LBPs [32](scylladb/cassandra-stress#32) Other Noticable Changes since the last version used in SCT: - Add support for hostname verification [31](scylladb/cassandra-stress#31) - Print thread dump on specific signals [27](scylladb/cassandra-stress#27) - Replace uninterruptible wait [26](scylladb/cassandra-stress#26) - Make it use DCAwareRoundRobinPolicy unless rack is provided [21](scylladb/cassandra-stress#21) - feature(docker): adding support for dependabot [19](scylladb/cassandra-stress#19) Signed-off-by: Dusan Malusev <[email protected]> (cherry picked from commit 02997a6)
Main reason for version change: Using cassandra-stress 3.17 to mittigate - Switch to ReplicaOrdering.RANDOM for select LBPs [32](scylladb/cassandra-stress#32) Other Noticable Changes since the last version used in SCT: - Add support for hostname verification [31](scylladb/cassandra-stress#31) - Print thread dump on specific signals [27](scylladb/cassandra-stress#27) - Replace uninterruptible wait [26](scylladb/cassandra-stress#26) - Make it use DCAwareRoundRobinPolicy unless rack is provided [21](scylladb/cassandra-stress#21) - feature(docker): adding support for dependabot [19](scylladb/cassandra-stress#19) Signed-off-by: Dusan Malusev <[email protected]> (cherry picked from commit 02997a6)
Main reason for version change: Using cassandra-stress 3.17 to mittigate - Switch to ReplicaOrdering.RANDOM for select LBPs [32](scylladb/cassandra-stress#32) Other Noticable Changes since the last version used in SCT: - Add support for hostname verification [31](scylladb/cassandra-stress#31) - Print thread dump on specific signals [27](scylladb/cassandra-stress#27) - Replace uninterruptible wait [26](scylladb/cassandra-stress#26) - Make it use DCAwareRoundRobinPolicy unless rack is provided [21](scylladb/cassandra-stress#21) - feature(docker): adding support for dependabot [19](scylladb/cassandra-stress#19) Signed-off-by: Dusan Malusev <[email protected]> (cherry picked from commit 02997a6)
Main reason for version change: Using cassandra-stress 3.17 to mittigate - Switch to ReplicaOrdering.RANDOM for select LBPs [32](scylladb/cassandra-stress#32) Other Noticable Changes since the last version used in SCT: - Add support for hostname verification [31](scylladb/cassandra-stress#31) - Print thread dump on specific signals [27](scylladb/cassandra-stress#27) - Replace uninterruptible wait [26](scylladb/cassandra-stress#26) - Make it use DCAwareRoundRobinPolicy unless rack is provided [21](scylladb/cassandra-stress#21) - feature(docker): adding support for dependabot [19](scylladb/cassandra-stress#19) Signed-off-by: Dusan Malusev <[email protected]> (cherry picked from commit 02997a6)
Main reason for version change: Using cassandra-stress 3.17 to mittigate - Switch to ReplicaOrdering.RANDOM for select LBPs [32](scylladb/cassandra-stress#32) Other Noticable Changes since the last version used in SCT: - Add support for hostname verification [31](scylladb/cassandra-stress#31) - Print thread dump on specific signals [27](scylladb/cassandra-stress#27) - Replace uninterruptible wait [26](scylladb/cassandra-stress#26) - Make it use DCAwareRoundRobinPolicy unless rack is provided [21](scylladb/cassandra-stress#21) - feature(docker): adding support for dependabot [19](scylladb/cassandra-stress#19) Signed-off-by: Dusan Malusev <[email protected]> (cherry picked from commit 02997a6)
Main reason for version change: Using cassandra-stress 3.17 to mittigate - Switch to ReplicaOrdering.RANDOM for select LBPs [32](scylladb/cassandra-stress#32) Other Noticable Changes since the last version used in SCT: - Add support for hostname verification [31](scylladb/cassandra-stress#31) - Print thread dump on specific signals [27](scylladb/cassandra-stress#27) - Replace uninterruptible wait [26](scylladb/cassandra-stress#26) - Make it use DCAwareRoundRobinPolicy unless rack is provided [21](scylladb/cassandra-stress#21) - feature(docker): adding support for dependabot [19](scylladb/cassandra-stress#19) Signed-off-by: Dusan Malusev <[email protected]> (cherry picked from commit 02997a6)
Main reason for version change: Using cassandra-stress 3.17 to mittigate - Switch to ReplicaOrdering.RANDOM for select LBPs [32](scylladb/cassandra-stress#32) Other Noticable Changes since the last version used in SCT: - Add support for hostname verification [31](scylladb/cassandra-stress#31) - Print thread dump on specific signals [27](scylladb/cassandra-stress#27) - Replace uninterruptible wait [26](scylladb/cassandra-stress#26) - Make it use DCAwareRoundRobinPolicy unless rack is provided [21](scylladb/cassandra-stress#21) - feature(docker): adding support for dependabot [19](scylladb/cassandra-stress#19) Signed-off-by: Dusan Malusev <[email protected]> (cherry picked from commit 02997a6)
Main reason for version change: Using cassandra-stress 3.17 to mittigate - Switch to ReplicaOrdering.RANDOM for select LBPs [32](scylladb/cassandra-stress#32) Other Noticable Changes since the last version used in SCT: - Add support for hostname verification [31](scylladb/cassandra-stress#31) - Print thread dump on specific signals [27](scylladb/cassandra-stress#27) - Replace uninterruptible wait [26](scylladb/cassandra-stress#26) - Make it use DCAwareRoundRobinPolicy unless rack is provided [21](scylladb/cassandra-stress#21) - feature(docker): adding support for dependabot [19](scylladb/cassandra-stress#19) Signed-off-by: Dusan Malusev <[email protected]> (cherry picked from commit 02997a6)
Main reason for version change: Using cassandra-stress 3.17 to mittigate - Switch to ReplicaOrdering.RANDOM for select LBPs [32](scylladb/cassandra-stress#32) Other Noticable Changes since the last version used in SCT: - Add support for hostname verification [31](scylladb/cassandra-stress#31) - Print thread dump on specific signals [27](scylladb/cassandra-stress#27) - Replace uninterruptible wait [26](scylladb/cassandra-stress#26) - Make it use DCAwareRoundRobinPolicy unless rack is provided [21](scylladb/cassandra-stress#21) - feature(docker): adding support for dependabot [19](scylladb/cassandra-stress#19) Signed-off-by: Dusan Malusev <[email protected]> (cherry picked from commit 02997a6)
Main reason for version change: Using cassandra-stress 3.17 to mittigate - Switch to ReplicaOrdering.RANDOM for select LBPs [32](scylladb/cassandra-stress#32) Other Noticable Changes since the last version used in SCT: - Add support for hostname verification [31](scylladb/cassandra-stress#31) - Print thread dump on specific signals [27](scylladb/cassandra-stress#27) - Replace uninterruptible wait [26](scylladb/cassandra-stress#26) - Make it use DCAwareRoundRobinPolicy unless rack is provided [21](scylladb/cassandra-stress#21) - feature(docker): adding support for dependabot [19](scylladb/cassandra-stress#19) Signed-off-by: Dusan Malusev <[email protected]> (cherry picked from commit 02997a6) # Conflicts: # defaults/docker_images/cassandra-stress/values_cassandra-stress.yaml
Main reason for version change: Using cassandra-stress 3.17 to mittigate - Switch to ReplicaOrdering.RANDOM for select LBPs [32](scylladb/cassandra-stress#32) Other Noticable Changes since the last version used in SCT: - Add support for hostname verification [31](scylladb/cassandra-stress#31) - Print thread dump on specific signals [27](scylladb/cassandra-stress#27) - Replace uninterruptible wait [26](scylladb/cassandra-stress#26) - Make it use DCAwareRoundRobinPolicy unless rack is provided [21](scylladb/cassandra-stress#21) - feature(docker): adding support for dependabot [19](scylladb/cassandra-stress#19) Signed-off-by: Dusan Malusev <[email protected]> (cherry picked from commit 02997a6) # Conflicts: # defaults/docker_images/cassandra-stress/values_cassandra-stress.yaml
The change adds ability to execute cassandra-stress with hostname verification, when client TLS/SSL encryption is enabled:
Fixes: #22