Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat): support for zarr-python>=3 #1726

Draft
wants to merge 71 commits into
base: main
Choose a base branch
from

Merge branch 'main' into ig/zarr_v3

122e311
Select commit
Loading
Failed to load commit list.
Draft

(feat): support for zarr-python>=3 #1726

Merge branch 'main' into ig/zarr_v3
122e311
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 4, 2025 in 0s

83.86% (target 80.00%)

View this Pull Request on Codecov

83.86% (target 80.00%)

Details

Codecov Report

Attention: Patch coverage is 90.19608% with 15 lines in your changes missing coverage. Please review.

Project coverage is 83.86%. Comparing base (8d7beab) to head (122e311).

Files with missing lines Patch % Lines
src/anndata/_io/specs/methods.py 93.54% 4 Missing ⚠️
src/anndata/_core/anndata.py 33.33% 2 Missing ⚠️
src/anndata/_io/zarr.py 81.81% 2 Missing ⚠️
src/anndata/_settings.py 80.00% 2 Missing ⚠️
src/anndata/compat/__init__.py 86.66% 2 Missing ⚠️
src/anndata/_io/h5ad.py 66.66% 1 Missing ⚠️
src/anndata/experimental/merge.py 92.30% 1 Missing ⚠️
src/anndata/tests/helpers.py 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1726      +/-   ##
==========================================
- Coverage   86.13%   83.86%   -2.28%     
==========================================
  Files          41       41              
  Lines        6277     6357      +80     
==========================================
- Hits         5407     5331      -76     
- Misses        870     1026     +156     
Files with missing lines Coverage Δ
src/anndata/_core/sparse_dataset.py 92.35% <100.00%> (+0.20%) ⬆️
src/anndata/_io/specs/registry.py 94.44% <100.00%> (-0.48%) ⬇️
src/anndata/_io/utils.py 76.33% <ø> (ø)
src/anndata/abc.py 100.00% <ø> (ø)
src/anndata/_io/h5ad.py 92.27% <66.66%> (-0.42%) ⬇️
src/anndata/experimental/merge.py 87.20% <92.30%> (-0.24%) ⬇️
src/anndata/tests/helpers.py 82.49% <93.33%> (-10.73%) ⬇️
src/anndata/_core/anndata.py 81.44% <33.33%> (-0.20%) ⬇️
src/anndata/_io/zarr.py 82.55% <81.81%> (-0.99%) ⬇️
src/anndata/_settings.py 94.33% <80.00%> (+0.22%) ⬆️
... and 2 more

... and 4 files with indirect coverage changes