feat(3241): add more options to build historical view #1322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jithine
reviewed
Jan 22, 2025
| @@ -23,7 +23,7 @@ export default Component.extend({ | |||
| lastRows: [], | |||
| moreJobs: true, | |||
| timestampPreference: null, | |||
| buildsHistoryOptions: [5, 10, 15, 20, 25, 30], | |||
| buildsHistoryOptions: [5, 10, 15, 20, 25, 30, 35, 40, 45, 50], | |||
There was a problem hiding this comment.
why 35, 50, 45 ? At higher limits, just jump by 20/10 at least.
|
I think the table should be changed to not have predefined history sizes in a dropdown at this point. We should change it so that it is an input field for users to set to whatever value they desire. |
|
Closed until further discussions/plans for addressing the historical builds is finalized. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
As of now users can only see up to 30 historical builds in the jobs list view.
Objective
This change is to add more options to allow users to view up to 50 historical builds.
References
screwdriver-cd/screwdriver#3241
screwdriver-cd/screwdriver#3200
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.