Cleanup pylintrc.

parsel/selector.py

@@ -337,7 +337,7 @@ def _get_root_and_type_from_text(
 
 
 def _get_root_type(root: Any, *, input_type: str | None) -> str:
-    if isinstance(root, etree._Element):  # pylint: disable=protected-access
+    if isinstance(root, etree._Element):
         if input_type in {"json", "text"}:
             raise ValueError(
                 f"Selector got an lxml.etree._Element object as root, "
@@ -354,8 +354,7 @@ def _is_valid_json(text: str) -> bool:
         json.loads(text)
     except (TypeError, ValueError):
         return False
-    else:
-        return True
+    return True
 
 
 def _load_json_or_none(text: str) -> Any:
@@ -602,7 +601,7 @@ def xpath(
         except etree.XPathError as exc:
             raise ValueError(f"XPath error: {exc} in {query}")
 
-        if type(result) is not list:
+        if not isinstance(result, list):
             result = [result]
 
         result = [

pylintrc

@@ -1,21 +1,20 @@
 [MASTER]
 ignore=typing
 persistent=no
+extension-pkg-allow-list=lxml
 
 [MESSAGES CONTROL]
-disable=c-extension-no-member,
-        fixme,
+enable=useless-suppression
+disable=fixme,
         import-error,
         import-outside-toplevel,
         invalid-name,
         line-too-long,
         missing-class-docstring,
         missing-function-docstring,
         missing-module-docstring,
-        no-else-return,
         no-member,
         not-callable,
-        parse-error,
         protected-access,
         raise-missing-from,
         redefined-builtin,
@@ -24,8 +23,5 @@ disable=c-extension-no-member,
         too-many-lines,
         too-many-positional-arguments,
         too-many-public-methods,
-        unidiomatic-typecheck,
         unused-argument,
-        use-a-generator,
-        wrong-import-order,
         wrong-import-position,

tests/test_selector_jmespath.py

@@ -161,10 +161,10 @@ def test_json_types(self) -> None:
         ):
             selector = Selector(text=text, root=_NOT_SET)
             self.assertEqual(selector.type, "json")
-            self.assertEqual(selector._text, text)  # pylint: disable=protected-access
+            self.assertEqual(selector._text, text)
             self.assertEqual(selector.root, root)
 
             selector = Selector(text=None, root=root)
             self.assertEqual(selector.type, "json")
-            self.assertEqual(selector._text, None)  # pylint: disable=protected-access
+            self.assertEqual(selector._text, None)
             self.assertEqual(selector.root, root)