-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tokenizer fixes and span_tokenize method #20
Open
chekunkov
wants to merge
267
commits into
scrapinghub:master
Choose a base branch
from
chekunkov:tokenizer_additional_fixes_and_span_method
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Tokenizer fixes and span_tokenize method #20
chekunkov
wants to merge
267
commits into
scrapinghub:master
from
chekunkov:tokenizer_additional_fixes_and_span_method
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…names_filename automatically
…less memory efficient)
Dropping it gives a nice speedup because computations are now in Cython.
…simplify code and make it faster. If needed, it can be implemented as a global feature.
…use code. span_tokenize method.
Conflicts: webstruct/text_tokenizers.py
@chekunkov do you by chance recall why wasn't this PR merged? |
@kmike nope, have no idea why. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tokenizer from #15 had issues like not splitting a dot at the end of a sentence as a separate token
Now this issue should be fixed.
Also I've refactored code and added span_tokenize method (@kmike I remember you said it would be nice to have this method)
Performance wasn't hurt