-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add NormalizeFieldKeys middleware #473
Conversation
(Thanks BTW ;)) |
(np BTW ;)) |
Also, noticed that |
Thanks @Technologicat !! Since I had a few minutes to spare, I offered some simplifying suggestions by adding to commits. Please don't hesitate to criticize / complement / revert. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go from my side!
4b328ba: Ok, nice shortened comment. Thanks. 71ee1de: Nice shortening of the test unit. Thanks! Regarding this commit, some minor comments: Contrary to the docstring, the function Personally, I'd also avoid the name (Using meaningful names exclusively is a habit I picked up from Racket docs ~half a decade ago. The standard metasyntactic names were fine in the 1970s, but we know better now. :) ) |
Sounds good! Would you like to make the changes? |
Sure, here they are. :) |
Ugh, a merge conflict. Fixed. And some Should be fine by me now. |
Thanks a million! |
Thanks for the merge! |
Here's an attempt at #467, which see.
Fixes #467