Skip to content

Commit

Permalink
Merge remote-tracking branch 'origin/v9-minor'
Browse files Browse the repository at this point in the history
  • Loading branch information
scip-ci committed Aug 20, 2024
2 parents 8e8cf2f + ee9929f commit ab3e0e7
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
1 change: 1 addition & 0 deletions CHANGELOG
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,7 @@ Fixed bugs
- maintain definition of artificial integral variables in xor constraints to avoid invalidations of conflict constraints
- free childless nodes only after the deactivation of the old focus path in treeSwitchPath() of tree.c
- only normalize rows for column norm evaluations in heur_shiftandpropagate.c to avoid unscaled violations
- expression handler for absolute value computes now also a cut when one of the bounds is infinite as long as the sign of the argument is known

Performance improvements
------------------------
Expand Down
4 changes: 2 additions & 2 deletions src/scip/cons_nonlinear.c
Original file line number Diff line number Diff line change
Expand Up @@ -807,7 +807,7 @@ SCIP_RETCODE freeVarExprs(

assert(consdata != NULL);

/* skip if we have stored the variable expressions already*/
/* skip if we have stored the variable expressions already */
if( consdata->varexprs == NULL )
return SCIP_OKAY;

Expand Down Expand Up @@ -14095,7 +14095,7 @@ SCIP_RETCODE SCIPaddExprNonlinear(

if( SCIPgetStage(scip) != SCIP_STAGE_PROBLEM )
{
SCIPerrorMessage("SCIPaddLinearVarNonlinear can only be called in problem stage.\n");
SCIPerrorMessage("SCIPaddExprNonlinear can only be called in problem stage.\n");
return SCIP_INVALIDCALL;
}

Expand Down
4 changes: 2 additions & 2 deletions src/scip/expr_abs.c
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ SCIP_RETCODE computeCutsAbs(
ub = bounds.sup;

/* it does not make sense to add a cut if child variable is unbounded or fixed */
if( !SCIPisInfinity(scip, -lb) && !SCIPisInfinity(scip, ub) && !SCIPisEQ(scip, lb, ub) )
if( !SCIPisEQ(scip, lb, ub) )
{
if( !SCIPisPositive(scip, ub) )
{
Expand All @@ -105,7 +105,7 @@ SCIP_RETCODE computeCutsAbs(
constant[*nreturned] = 0.0;
(*nreturned)++;
}
else
else if( !SCIPisInfinity(scip, -lb) && !SCIPisInfinity(scip, ub) )
{
/* z = abs(x), x still has mixed sign */
SCIP_Real alpha;
Expand Down

0 comments on commit ab3e0e7

Please sign in to comment.