-
-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alternative build system to #59 #66
base: main
Are you sure you want to change the base?
Conversation
I used a script to autoconvert all the |
I managed to figure out how to unwind my "convert all ipynb -> md w/ jupytext" commit and limit the conversions to only those files that are actually used in the site (so far). The toctrees in |
I'm partial to CircleCI for building sphinx sites because of the nice preview options but I didn't bother adding a whole new CI service in this PR. In the absence of a CI preview, here's what the site looks like rendered as of 8b7a95a : https://rossbar.github.io/skimage-tutorials/ |
Hey, Ross, this looks great and is a huge improvement over what we have right now. I'm happy to merge, but there's a small issue with the "imageconverts" package not found. |
Gah a silly mistake, it should be |
The build failed, but it's hard to see why. How about adding those logs as build artifacts? |
One of the advantages of this build system is that failures in the notebook execution actually show up in the rendered site. The
It looks like there was also a cell execution timeout in I've found that CircleCI is really a great fit for this workflow because you can upload the |
@rossbar Would you like to add CircleCI now or do that in another PR? I'm happy with either. |
This draft PR follows from the discussion in #59. To test this build system:
This is the standard
Makefile
you get fromsphinx-quickstart
. I incorporated @stefanv's fixes to make some of the examples run again, but there were some that haven't been fixed yet, e.g.adv{3, 4, 5}_*
. Even though these notebooks encounter exceptions, they site is still generated and can still be viewed in the browser (e.g.firefox _build/html/index.html
). This is really handy for reviewing and works will with common CI site preview workflows. The caching is now handled byjupyter_cache
rather than being handled in a Makefile. It's not perfect (and doesn't handle dependencies anywhere near as nicely as a Makefile does) but should have the property that only notebooks that have been modified will be executed on a rebuild.