SKETCH-2182: Fixing Ubuntu builds #13
Open
+58
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This diff gets building working on the Ubuntu runner. The required changes are:
xvfb-run
to launch the tests so that we can instantiate a QApplication.There's one additional change that's not strictly required, but it makes life easier: adding
to the
CMAKE_ARGS
for building Qt. Without that, the build output for Qt contains several hundred lines complaining that the policies aren't set. According to the CMake documentation, "policies" are kind of like long-term feature flags for any CMake changes that break backwards compatibility. If you don't set the policy, you get the backwards-compatible but probably broken behavior (since they probably wouldn't have bothered to change it unless there was an issue) plus a warning every single time your build does anything that could potentially be affected by the behavior.Testing Done
The two automated tests now pass.