Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix INSTALL instructions for newer versions of pip #418

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

jrom99
Copy link
Contributor

@jrom99 jrom99 commented Jan 10, 2025

Split from #400

I updated the INSTALL file to reflect changes to pip install . since pip23 and pip24, where all arguments must be in a key=value form. I took the liberty to change how some optional dependencies can be set/unset to be more explicit (--no-libxml is now --libxml=false), and as far as I've checked, they are not used in the current github workflow.

I couldn't find how to set PYMOL_PATH in a way that pip install . is able to listen:

  • Raises unknown argument error:
    pip install . --config-settings pymol-path=/some/path
    pip install . --config-settings pymol_path=/some/path
  • Ignored (pymol is placed in venvprefix/bin/pymol or pythonuserbase/bin/pymol):
    PYMOL_PATH=/some/path/ pip install .
    env PYMOL_PATH=/some/path/ pip install .

@JarrettSJohnson
Copy link
Member

Thanks. LGTM. I do prefer affirmative parse arg names like this. Seems more consistent and less error-prone.

@JarrettSJohnson JarrettSJohnson merged commit 1f6e7b3 into schrodinger:master Jan 25, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants