Enable Link-Time Optimization (LTO) for the Rust part #1011
Conversation
Yep.
Just did it :) |
| @@ -13,3 +13,6 @@ members = ["rust/scx_stats", | |||
| "scheds/rust/scx_layered", | |||
| "scheds/rust/scx_mitosis"] | |||
| resolver = "2" | |||
|
|
|||
| [profile.release] | |||
There was a problem hiding this comment.
Maybe it's better to add another profile instead:
[profile.release-lto]
inherits = "release"
lto = true
There was a problem hiding this comment.
Personally I would prefer, that the default would use LTO, and for the CI we pass LTO off or so.
There was a problem hiding this comment.
The meson flag can be added, then we activate this in PKGBUILD.
|
What is pending here? |
|
I was waiting for the final decision about how exactly LTO should be enabled for the project: in a dedicated profile or in the regular Release Cargo profile; do I need to patch Meson build scripts in this PR too, etc. As far as I understand, no final agreement has been reached yet. |
|
I don't see a reason to not enable it by default on release builds. Let's enable it and see whether anyone complains. |
Enable Link-Time Optimization (LTO) for Rust schedulers. It improves the binary size and allows to a compiler perform more aggressive optimizations. More details in sched-ext#1010
Head branch was pushed to by a user without write access
Related to #1010 but doesn't completely resolve it