ARTESCA-13972 // Migration to React 18 #792

hervedombya · 2025-01-08T12:14:03Z

No description provided.

bert-e · 2025-01-08T12:14:07Z

Hello hervedombya,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
`/after_pull_request`	Wait for the given pull request id to be merged before continuing with the current one.
`/bypass_author_approval`	Bypass the pull request author's approval	⭐
`/bypass_build_status`	Bypass the build and test status	⭐
`/bypass_commit_size`	Bypass the check on the size of the changeset `TBA`	⭐
`/bypass_incompatible_branch`	Bypass the check on the source branch prefix	⭐
`/bypass_jira_check`	Bypass the Jira issue check	⭐
`/bypass_peer_approval`	Bypass the pull request peers' approval	⭐
`/bypass_leader_approval`	Bypass the pull request leaders' approval	⭐
`/approve`	Instruct Bert-E that the author has approved the pull request.		✍️
`/create_pull_requests`	Allow the creation of integration pull requests.
`/create_integration_branches`	Allow the creation of integration branches.
`/no_octopus`	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
`/unanimity`	Change review acceptance criteria from `one reviewer at least` to `all reviewers`
`/wait`	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
`/help`	Print Bert-E's manual in the pull request.
`/status`	Print Bert-E's current status in the pull request `TBA`
`/clear`	Remove all comments from Bert-E from the history `TBA`
`/retry`	Re-start a fresh build `TBA`
`/build`	Re-start a fresh build `TBA`
`/force_reset`	Delete integration branches & pull requests, and restart merge process from the beginning.
`/reset`	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

bert-e · 2025-01-08T12:14:13Z

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

bert-e · 2025-01-08T13:25:11Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2025-01-09T15:42:08Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2025-01-10T16:39:12Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2025-01-11T15:01:41Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2025-01-13T16:33:14Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2025-01-16T08:42:51Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2025-01-17T07:59:21Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2025-01-18T16:03:23Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

bert-e · 2025-01-20T11:03:17Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

codecov · 2025-01-20T11:13:39Z

Codecov Report

Attention: Patch coverage is 43.53312% with 179 lines in your changes missing coverage. Please review.

Project coverage is 59.16%. Comparing base (23fe25f) to head (c3518e0).
Report is 19 commits behind head on development/3.0.

Files with missing lines	Patch %	Lines
src/react/Routes.tsx	0.00%	26 Missing ⚠️
src/react/next-architecture/ui/ConfigProvider.tsx	23.80%	16 Missing ⚠️
.../react/account/AccountRoleSelectButtonAndModal.tsx	0.00%	13 Missing ⚠️
src/react/workflow/Workflows.tsx	25.00%	9 Missing ⚠️
src/react/workflow/CreateWorkflow.tsx	30.00%	7 Missing ⚠️
src/react/databrowser/buckets/Buckets.tsx	0.00%	6 Missing ⚠️
src/react/databrowser/buckets/BucketList.tsx	0.00%	5 Missing ⚠️
src/react/ui-elements/Breadcrumb.tsx	44.44%	5 Missing ⚠️
src/react/account/AccountPoliciesList.tsx	42.85%	4 Missing ⚠️
src/react/account/AccountUserList.tsx	50.00%	4 Missing ⚠️
... and 43 more

Additional details and impacted files

@@                 Coverage Diff                 @@
##           development/3.0     #792      +/-   ##
===================================================
- Coverage            61.53%   59.16%   -2.38%     
===================================================
  Files                  240      241       +1     
  Lines                11578    11659      +81     
  Branches              3324     3336      +12     
===================================================
- Hits                  7125     6898     -227     
- Misses                4433     4737     +304     
- Partials                20       24       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

refactor: update imports to use ShellHooksContext for authentication refactor: replace useAuth imports with useShellHooks for improved context management refactor: replace history.push with navigate for improved routing consistency fix: correct typo in workflows route and adjust account creation routes for consistency refactor: update type definitions to use React 18 JSX runtime and improve context imports refactor: replace history.replace with navigate for improved routing consistency refactor: replace history.location with useLocation for improved routing consistency fix useBasenameAndRelativeNavigate refactor: update routing links to use basePath for consistency and improve navigation refactor: update import paths for IconHelp and adjust route paths for improved consistency feat: add QueryClientProvider and enhance routing with accountName parameter; update mocks and improve navigation consistency refactor: update imports for QueryClientProvider and enhance routing consistency with basePath in navigation links refactor: update import for QueryClientProvider in VeeamWelcomeModal test file to enhance consistency with other components refactor: remove unused RemoteKeys type definition, update imports to use useShellHooks for authentication, and enhance routing consistency with useLocation and useBasenameRelativeNavigate refactor: update imports from 'react-router-dom' to 'react-router' for improved consistency across components and enhance routing practices refactor: streamline routing and import practices across components; remove console.log, enhance test consistency, and update path definitions for improved clarity refactor: enhance test structure and consistency by updating imports, utilizing NewWrapper for rendering, and improving component interactions across various LocationDetails tests refactor: update test implementations to use screen and container for element queries, enhance rendering with NewWrapper, and improve consistency in LocationDetails and Properties tests refactor: streamline test implementations by replacing deprecated element queries with container queries, enhance consistency in LocationDetails tests, and improve error handling in action dispatch tests refactor: update imports in multiple components to include JSX for improved type support and consistency across the application refactor: update imports across multiple components to include JSX for improved type support and consistency in the application refactor: update path matching in InternalRoutes to enforce strict matching, and add JSX imports in Breadcrumb and storageOptions for improved type support and consistency refactor: enhance LocationDetailsNFS tests by updating imports, improving element queries for better consistency, and ensuring proper rendering with NewWrapper; removed deprecated value checks in favor of presence checks refactor: enhance locations tests by adding ShellHooksProvider for improved context management, updating imports for mock utilities, and ensuring proper promise handling for asynchronous operations refactor: enhance InternalRoutes path matching by adding support for properties and specific bucket names, improving route handling and consistency across account-related routes feat: add new account management routes and update navigation paths for user and policy creation refactor: update path properties in AttachmentTabs to use empty string instead of pathname for improved clarity and consistency in tab navigation refactor: streamline test implementations by updating imports, enhancing element queries, and improving asynchronous handling across multiple test files fix: handle optional messages in networkActivity reducer and update test case for ReauthDialog refactor: update useShellHooks import to use @scality/module-federation fix: update retrieveConfiguration call in CertificateDownloadButton refactor: enhance jest setup with mockShellAlerts and mockShellHooks chore: update @scality/core-ui to version 0.155.0 and @scality/module-federation to version 1.4.0 refactor: update useBasenameRelativeNavigate import to use @scality/module-federation refactor: remove unused ShellHooksContext and update jest timeouts to 18 seconds for improved test reliability refactor: update @scality/module-federation mock to use actual router's useNavigate refactor: update test cases in Attachments.test.tsx for clarity and consistency; modify HeaderButtons and Breadcrumb components to improve pathname matching refactor: enhance routing consistency by updating bucket navigation paths and internal route matching for account-related routes refactor: reorganize imports and streamline routing in AccountContent and Breadcrumb components for improved consistency and clarity refactor: streamline route matching in InternalRoutes, enhance breadcrumb functionality with basePath, and update object management components for improved navigation consistency

bert-e · 2025-01-23T15:06:20Z

Waiting for approval

The following approvals are needed before I can proceed with the merge:

the author
one peer

Peer approvals must include at least 1 approval from the following list:

hervedombya · 2025-01-23T15:08:10Z

/approve

bert-e · 2025-01-23T15:08:19Z

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

✔️ development/3.0

The following branches will NOT be impacted:

development/1.4
development/1.5
development/1.6
development/2.0
development/2.1
development/2.2

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

Any commit you add on the source branch will trigger a new cycle after the
current queue is merged.
Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

bert-e · 2025-01-23T15:12:32Z

I have successfully merged the changeset of this pull request
into targetted development branches:

✔️ development/3.0

The following branches have NOT changed:

development/1.4
development/1.5
development/1.6
development/2.0
development/2.1
development/2.2

Please check the status of the associated issue ARTESCA-13972.

Goodbye hervedombya.

hervedombya changed the base branch from development/2.2 to development/3.0 January 8, 2025 13:25

hervedombya force-pushed the feature/ARTESCA-13972 branch 2 times, most recently from 673b122 to ecfaf7c Compare January 16, 2025 14:27

hervedombya force-pushed the feature/ARTESCA-13972 branch from 7d97898 to a2b2830 Compare January 20, 2025 15:25

hervedombya force-pushed the feature/ARTESCA-13972 branch from eb27789 to 46197a4 Compare January 21, 2025 09:14

JBWatenbergScality approved these changes Jan 23, 2025

View reviewed changes

bert-e merged commit 3261504 into development/3.0 Jan 23, 2025
9 checks passed

bert-e deleted the feature/ARTESCA-13972 branch January 23, 2025 15:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ARTESCA-13972 // Migration to React 18 #792

ARTESCA-13972 // Migration to React 18 #792

hervedombya commented Jan 8, 2025

bert-e commented Jan 8, 2025

bert-e commented Jan 8, 2025

bert-e commented Jan 8, 2025

bert-e commented Jan 9, 2025

bert-e commented Jan 10, 2025

bert-e commented Jan 11, 2025

bert-e commented Jan 13, 2025

bert-e commented Jan 16, 2025

bert-e commented Jan 17, 2025

bert-e commented Jan 18, 2025

bert-e commented Jan 20, 2025

codecov bot commented Jan 20, 2025

bert-e commented Jan 23, 2025

hervedombya commented Jan 23, 2025

bert-e commented Jan 23, 2025

bert-e commented Jan 23, 2025

ARTESCA-13972 // Migration to React 18 #792

ARTESCA-13972 // Migration to React 18 #792

Conversation

hervedombya commented Jan 8, 2025

bert-e commented Jan 8, 2025

Hello hervedombya,

bert-e commented Jan 8, 2025

Request integration branches

bert-e commented Jan 8, 2025

Waiting for approval

bert-e commented Jan 9, 2025

Waiting for approval

bert-e commented Jan 10, 2025

Waiting for approval

bert-e commented Jan 11, 2025

Waiting for approval

bert-e commented Jan 13, 2025

Waiting for approval

bert-e commented Jan 16, 2025

Waiting for approval

bert-e commented Jan 17, 2025

Waiting for approval

bert-e commented Jan 18, 2025

Waiting for approval

bert-e commented Jan 20, 2025

Waiting for approval

codecov bot commented Jan 20, 2025

Codecov Report

bert-e commented Jan 23, 2025

Waiting for approval

hervedombya commented Jan 23, 2025

bert-e commented Jan 23, 2025

In the queue

bert-e commented Jan 23, 2025