Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support erasing inflights in CompleteMPU and AbortMPU #5719

Merged
merged 5 commits into from
Jan 9, 2025

Conversation

williamlardier
Copy link
Contributor

The added test ensure that the logic within the API is coherent, as unit testing is not possible here.

francoisferrand and others added 3 commits December 20, 2024 09:49
- The action for abort is multipartDelete
- Substract the total part size with the stored size in complete
  MPU API, so we can deduce the size we drop. The locations
  object does not hold the size.
- Same approach for the AbortMPU API.

Issue: CLDSRV-592
@bert-e
Copy link
Contributor

bert-e commented Dec 20, 2024

Hello williamlardier,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Dec 20, 2024

Incorrect fix version

The Fix Version/s in issue CLDSRV-592 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.8.40

  • 9.0.0

Please check the Fix Version/s of CLDSRV-592, or the target
branch of this pull request.

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.

Project coverage is 62.90%. Comparing base (2c8ff15) to head (7e9954d).
Report is 22 commits behind head on development/8.8.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
lib/api/completeMultipartUpload.js 80.00% 2 Missing ⚠️
lib/api/apiUtils/object/abortMultipartUpload.js 83.33% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
lib/api/api.js 81.91% <ø> (+81.91%) ⬆️
...i/apiUtils/authorization/prepareRequestContexts.js 89.76% <100.00%> (+0.24%) ⬆️
lib/api/apiUtils/object/abortMultipartUpload.js 84.81% <83.33%> (-0.33%) ⬇️
lib/api/completeMultipartUpload.js 80.61% <80.00%> (+0.08%) ⬆️

... and 14 files with indirect coverage changes

@@                 Coverage Diff                 @@
##           development/8.8    #5719      +/-   ##
===================================================
+ Coverage            60.55%   62.90%   +2.35%     
===================================================
  Files                  185      185              
  Lines                11617    11631      +14     
===================================================
+ Hits                  7035     7317     +282     
+ Misses                4582     4314     -268     
Flag Coverage Δ
unit 62.90% <84.21%> (+2.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

- Not all code is tested, but relevant parts for quota

Issue: CLDSRV-592
lib/api/api.js Outdated Show resolved Hide resolved
@bert-e
Copy link
Contributor

bert-e commented Jan 6, 2025

Incorrect fix version

The Fix Version/s in issue CLDSRV-592 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.8.41

  • 9.0.0

Please check the Fix Version/s of CLDSRV-592, or the target
branch of this pull request.

@williamlardier
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Jan 9, 2025

Integration data created

I have created the integration data for the additional destination branches.

  • this pull request will merge bugfix/CLDSRV-592 into
    development/8.8
  • w/9.0/bugfix/CLDSRV-592 will be merged into development/9.0

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/7.70

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jan 9, 2025

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/8.8

  • ✔️ development/9.0

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/7.70

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jan 9, 2025

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.8

  • ✔️ development/9.0

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70

Please check the status of the associated issue CLDSRV-592.

Goodbye williamlardier.

@bert-e bert-e merged commit d6bfe84 into development/8.8 Jan 9, 2025
19 checks passed
@bert-e bert-e deleted the bugfix/CLDSRV-592 branch January 9, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants