Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDSRV-429: update get apis with impDeny logic #5461

Closed

Conversation

benzekrimaha
Copy link
Contributor

@benzekrimaha benzekrimaha commented Nov 28, 2023

Bucket policies are not correctly interpreted, this is part of the following epic to fix that: scality/Arsenal#2181

This PR is aiming to update get apis since object and bucket authorisations are made at API level and need to support implicit denies, ticket linked to this issue here : https://scality.atlassian.net/browse/CLDSRV-429

PRs providing implicit Deny logic to CS for processing in this PR
scality/Arsenal#2181
https://github.com/scality/Vault/pull/2135
#5322
#5420
#5432
#5456

Here CI links for zenko tests :

I'll be bumping a new CLDSRV once the reviews done as these are changes that will be tested against Integration

@benzekrimaha benzekrimaha force-pushed the improvement/CLDSRV-429-get-apis-impDeny branch 2 times, most recently from 82fc47b to 924374e Compare November 29, 2023 10:31
Base automatically changed from improvement/CLDSRV-428-put-apis-impDeny to development/7.10 November 29, 2023 17:33
@bert-e
Copy link
Contributor

bert-e commented Nov 29, 2023

Hello benzekrimaha,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Nov 29, 2023

Incorrect fix version

The Fix Version/s in issue CLDSRV-429 contains:

  • 7.10.35

  • 7.70.32

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 7.10.35

  • 7.70.32

  • 8.6.13

  • 8.7.32

  • 8.8.6

Please check the Fix Version/s of CLDSRV-429, or the target
branch of this pull request.

@benzekrimaha
Copy link
Contributor Author

ping

@bert-e
Copy link
Contributor

bert-e commented Nov 29, 2023

Incorrect fix version

The Fix Version/s in issue CLDSRV-429 contains:

  • 7.10.36

  • 7.70.33

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 7.10.36

  • 7.70.33

  • 8.6.14

  • 8.7.33

  • 8.8.7

Please check the Fix Version/s of CLDSRV-429, or the target
branch of this pull request.

@benzekrimaha
Copy link
Contributor Author

ping for versions

@bert-e
Copy link
Contributor

bert-e commented Nov 30, 2023

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@benzekrimaha benzekrimaha force-pushed the improvement/CLDSRV-429-get-apis-impDeny branch from 924374e to 7d10e5d Compare November 30, 2023 15:17
@benzekrimaha benzekrimaha deleted the improvement/CLDSRV-429-get-apis-impDeny branch November 30, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants