Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDSRV-452: Id and principal on policy hotfixbranch #5383

Conversation

benzekrimaha
Copy link
Contributor

@benzekrimaha benzekrimaha commented Oct 9, 2023

Pull request template

Description

Motivation and context

This PR adds the arsenal version that support of the Id definition on resource policy document and principal length restriction on both resource and user policy

Ticket link : https://scality.atlassian.net/browse/CLDSRV-452
ARSN PR link : scality/Arsenal#2178

I am aiming for the hotfix/7.10.8 branch on Federation , here's the link showing the cldsrv version used in there: https://github.com/scality/Federation/blob/54ef0fdca84a8f5a64ffe28eaef816daf5f42d53/group_vars/all#L141

Tests were added as well

@bert-e
Copy link
Contributor

bert-e commented Oct 9, 2023

Hello benzekrimaha,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Oct 9, 2023

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@benzekrimaha benzekrimaha marked this pull request as ready for review October 9, 2023 15:23
@benzekrimaha
Copy link
Contributor Author

@bert-e approve

@bert-e
Copy link
Contributor

bert-e commented Oct 10, 2023

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ hotfix/7.10.30

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.6
  • development/8.7
  • development/8.8

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Oct 10, 2023

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ hotfix/7.10.30

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.6
  • development/8.7
  • development/8.8

Please check the status of the associated issue CLDSRV-452.

Goodbye benzekrimaha.

@bert-e bert-e merged commit 3e97e8f into hotfix/7.10.30 Oct 10, 2023
@bert-e bert-e deleted the bugfix/CLDSRV-452-id-and-principal-on-policy-hotfixbranche branch October 10, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants