Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement/cldsrv 426 acl imp deny #5323

Closed
wants to merge 2 commits into from

Conversation

KazToozs
Copy link

Pull request template
Description
Motivation and context
Why is this change required? What problem does it solve?
Bucket policies are not correctly interpreted, this is part of the following epic to fix that: scality/Arsenal#2162

Related issues
PRs providing implicit Deny logic to CS for processing in this PR
scality/Arsenal#2162
https://github.com/scality/Vault/pull/2134
#5288

Checklist
Add tests to cover the changes
New tests added or existing tests modified to cover all changes

Code conforms with the style guide
Sign your work
In order to contribute to the project, you must sign your work
https://github.com/scality/Guidelines/blob/master/CONTRIBUTING.md#sign-your-work

Thank you again for contributing! We will try to test and integrate the change
as soon as we can.

@bert-e
Copy link
Contributor

bert-e commented Sep 11, 2023

Hello kaztoozs,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Sep 11, 2023

Branches have diverged

This pull request's source branch improvement/CLDSRV-426-acl-impDeny has diverged from
development/8.7 by more than 50 commits.

To avoid any integration risks, please re-synchronize them using one of the
following solutions:

  • Merge origin/development/8.7 into improvement/CLDSRV-426-acl-impDeny
  • Rebase improvement/CLDSRV-426-acl-impDeny onto origin/development/8.7

Note: If you choose to rebase, you may have to ask me to rebuild
integration branches using the reset command.

@KazToozs KazToozs changed the base branch from development/8.7 to improvement/CLDSRV-424-apicall-auth-update September 11, 2023 16:17
@KazToozs KazToozs force-pushed the improvement/CLDSRV-426-acl-impDeny branch 2 times, most recently from 93e886c to 0f64e7c Compare September 18, 2023 16:39
@benzekrimaha benzekrimaha force-pushed the improvement/CLDSRV-424-apicall-auth-update branch 4 times, most recently from abf52ba to 1542075 Compare November 3, 2023 11:39
@benzekrimaha benzekrimaha force-pushed the improvement/CLDSRV-424-apicall-auth-update branch from 72fd343 to 6abb0d9 Compare November 7, 2023 08:08
Base automatically changed from improvement/CLDSRV-424-apicall-auth-update to development/7.10 November 7, 2023 09:58
@bert-e
Copy link
Contributor

bert-e commented Nov 7, 2023

Incorrect fix version

The Fix Version/s in issue CLDSRV-426 contains:

  • 7.10.31

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 7.10.33

  • 7.70.30

  • 8.6.12

  • 8.7.31

  • 8.8.5

Please check the Fix Version/s of CLDSRV-426, or the target
branch of this pull request.

@benzekrimaha benzekrimaha force-pushed the improvement/CLDSRV-426-acl-impDeny branch 3 times, most recently from 66a14c2 to 3c129fe Compare November 7, 2023 10:20
@benzekrimaha benzekrimaha force-pushed the improvement/CLDSRV-426-acl-impDeny branch from 3c129fe to c280846 Compare November 7, 2023 10:35
CLDSRV-426: add tests for ACL permission check updates

CLDSRV-426: add tests for ACL permission check updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants