Require oplog update only when archived

An oplog update is only required when the object is archived, instead of
when lifecycle is enabled: so fix the condition to avoid extra
associated load.

The update is also required when bucket notification is enabled on the
bucket, no change there.

Issue: CLDSRV-563

lib/api/apiUtils/object/deleteObject.js

@@ -1,18 +1,22 @@
 /**
  * _bucketRequiresOplogUpdate - DELETE an object from a bucket
- * @param {BucketInfo} bucket - bucket object
+ * @param {ObjectMD} objMD - object metadata
+ * @param {BucketInfo} bucket - bucket info
  * @return {boolean} whether objects require oplog updates on deletion, or not
  */
-function _bucketRequiresOplogUpdate(bucket) {
+function _deleteRequiresOplogUpdate(objMD, bucket) {
+    // If the object is archived, an oplog update is required
+    if (objMD.archive) {
+        return true;
+    }
     // Default behavior is to require an oplog update
-    if (!bucket || !bucket.getLifecycleConfiguration || !bucket.getNotificationConfiguration) {
+    if (!bucket || !bucket.getNotificationConfiguration) {
         return true;
     }
-    // If the bucket has lifecycle configuration or notification configuration
-    // set, we also require an oplog update
-    return bucket.getLifecycleConfiguration() || bucket.getNotificationConfiguration();
+    // If the bucket has notification configuration set, we also require an oplog update
+    return bucket.getNotificationConfiguration();
 }
 
 module.exports = {
-    _bucketRequiresOplogUpdate,
+    _deleteRequiresOplogUpdate,
 };

lib/api/multiObjectDelete.js

@@ -25,7 +25,7 @@ const { hasGovernanceBypassHeader, checkUserGovernanceBypass, ObjectLockInfo }
 const requestUtils = policies.requestUtils;
 const { validObjectKeys } = require('../routes/routeVeeam');
 const { deleteVeeamCapabilities } = require('../routes/veeam/delete');
-const { _bucketRequiresOplogUpdate } = require('./apiUtils/object/deleteObject');
+const { _deleteRequiresOplogUpdate } = require('./apiUtils/object/deleteObject');
 const { overheadField } = require('../../constants');
 
 const versionIdUtils = versioning.VersionID;
@@ -345,7 +345,7 @@ function getObjMetadataAndDelete(authInfo, canonicalID, request,
                     if (options && options.deleteData) {
                         options.overheadField = overheadField;
                         deleteInfo.deleted = true;
-                        if (!_bucketRequiresOplogUpdate(bucket)) {
+                        if (!_deleteRequiresOplogUpdate(objMD, bucket)) {
                             options.doesNotNeedOpogUpdate = true;
                         }
                         if (objMD.uploadId) {

lib/api/objectDelete.js

@@ -13,7 +13,7 @@ const monitoring = require('../utilities/monitoringHandler');
 const { hasGovernanceBypassHeader, ObjectLockInfo }
     = require('./apiUtils/object/objectLockHelpers');
 const { config } = require('../Config');
-const { _bucketRequiresOplogUpdate } = require('./apiUtils/object/deleteObject');
+const { _deleteRequiresOplogUpdate } = require('./apiUtils/object/deleteObject');
 
 const versionIdUtils = versioning.VersionID;
 const objectLockedError = new Error('object locked');
@@ -182,7 +182,7 @@ function objectDeleteInternal(authInfo, request, log, isExpiration, cb) {
                     delOptions.replayId = objectMD.uploadId;
                 }
 
-                if (!_bucketRequiresOplogUpdate(bucketMD)) {
+                if (!_deleteRequiresOplogUpdate(objectMD, bucketMD)) {
                     delOptions.doesNotNeedOpogUpdate = true;
                 }