Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new component label #4738

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: new component label #4738

wants to merge 2 commits into from

Conversation

lisalupi
Copy link
Contributor

@lisalupi lisalupi commented Feb 5, 2025

Summary

Type

  • Feature

Summarise concisely:

New component Label that can be used to replace the prop label inside input components (DateInput, TextInputV2...).
Also, those components (the non-deprecated ones) use Label now!

@lisalupi lisalupi added the enhancement New feature or request label Feb 5, 2025
@lisalupi lisalupi self-assigned this Feb 5, 2025
@lisalupi lisalupi requested review from johnrazeur, a team and matthprost as code owners February 5, 2025 17:03
Copy link

changeset-bot bot commented Feb 5, 2025

🦋 Changeset detected

Latest commit: 1a7bab7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Minor
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 86.48649% with 5 lines in your changes missing coverage. Please review.

Project coverage is 89.11%. Comparing base (fc68c84) to head (1a7bab7).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/ui/src/components/NumberInputV2/index.tsx 0.00% 2 Missing ⚠️
packages/ui/src/components/TagInput/index.tsx 0.00% 2 Missing ⚠️
packages/ui/src/components/TimeInputV2/index.tsx 80.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4738      +/-   ##
==========================================
+ Coverage   88.98%   89.11%   +0.12%     
==========================================
  Files         227      228       +1     
  Lines        7974     7948      -26     
  Branches     3666     3635      -31     
==========================================
- Hits         7096     7083      -13     
+ Misses        878      865      -13     
Files with missing lines Coverage Δ
packages/ui/src/components/Label/index.tsx 100.00% <100.00%> (ø)
packages/ui/src/components/ProgressBar/index.tsx 100.00% <ø> (ø)
packages/ui/src/components/SelectInputV2/index.tsx 81.57% <100.00%> (-0.93%) ⬇️
packages/ui/src/components/TextArea/index.tsx 97.93% <100.00%> (+0.90%) ⬆️
packages/ui/src/components/TextInputV2/index.tsx 89.74% <100.00%> (+0.39%) ⬆️
packages/ui/src/components/UnitInput/index.tsx 98.92% <100.00%> (ø)
...kages/ui/src/components/VerificationCode/index.tsx 99.37% <100.00%> (+1.18%) ⬆️
packages/ui/src/components/TimeInputV2/index.tsx 98.13% <80.00%> (-0.46%) ⬇️
packages/ui/src/components/NumberInputV2/index.tsx 97.82% <0.00%> (+3.42%) ⬆️
packages/ui/src/components/TagInput/index.tsx 95.10% <0.00%> (+3.21%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb9e923...1a7bab7. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants