Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Javadoc warning in integration test #2484

Merged
merged 3 commits into from
Feb 3, 2025
Merged

Conversation

Torch3333
Copy link
Contributor

@Torch3333 Torch3333 commented Jan 28, 2025

Description

This fixes Javadoc warning when compiling the project.

Related issues and/or PRs

N/A

Changes made

Fix javadoc comment.

Checklist

The following is a best-effort checklist. If any items in this checklist are not applicable to this PR or are dependent on other, unmerged PRs, please still mark the checkboxes after you have read and understood each item.

  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes.
  • Any remaining open issues linked to this PR are documented and up-to-date (Jira, GitHub, etc.).
  • Tests (unit, integration, etc.) have been added for the changes.
  • My changes generate no new warnings.
  • Any dependent changes in other PRs have been merged and published.

Additional notes (optional)

N/A

Release notes

N/A

@Torch3333 Torch3333 self-assigned this Jan 28, 2025
@Torch3333 Torch3333 force-pushed the fix_javadoc_warning branch from 02e0e92 to d94b6ad Compare January 28, 2025 03:08
@Torch3333 Torch3333 marked this pull request as ready for review January 30, 2025 07:48
Copy link
Collaborator

@brfrn169 brfrn169 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

* @param namespace the namespace of the table
* @param table the table name
* @return a Get operation to retrieve the record inserted with {@link #getPut(String, String)}
* * or {@link #getInsert(String, String)}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* * or {@link #getInsert(String, String)}
* or {@link #getInsert(String, String)}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, 😑
Thank you!

@brfrn169 brfrn169 requested a review from komamitsu January 31, 2025 05:40
Copy link
Contributor

@komamitsu komamitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@brfrn169 brfrn169 merged commit 4d6848c into master Feb 3, 2025
48 checks passed
@brfrn169 brfrn169 deleted the fix_javadoc_warning branch February 3, 2025 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants