improvement: Further heuristic improvements #6658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Couple of related improvements: - escape operators, they are escaped for semanticdb symbols ( otherwise ??? will not be found) - add standard Scala imports (needed for scala.Predef.`???`().) - also try and guess method with (). ending - check if the returned symbol is exactly the same as we were looking for (could not reproduce it 100% the same as I encountered in the wild, but it's close enough)
kasiaMarek
approved these changes
Aug 19, 2024
| @@ -56,7 +56,7 @@ class FallbackDefinitionProvider( | |||
| .value | |||
| if (isInSelectPosition) List(symbolPrefix + ".") | |||
| else if (isInTypePosition) List(symbolPrefix + "#") | |||
| else List(".", "#").map(ending => symbolPrefix + ending) | |||
| else List(".", "#", "().").map(ending => symbolPrefix + ending) | |||
There was a problem hiding this comment.
You could possibly improve by finding all overridden method symbols using the same strategy as ScaladocDefinitionProvider#findAllOverLoadedMethods.
There was a problem hiding this comment.
I will work on a follow up next week, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple of related improvements:
???().)