fix: report error only on an empty definition

scalameta · Jan 24, 2025 · 4b6c358 · 4b6c358
1 parent 8168b51
commit 4b6c358
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/metals/src/main/scala/scala/meta/internal/metals/DefinitionProvider.scala b/metals/src/main/scala/scala/meta/internal/metals/DefinitionProvider.scala
@@ -98,9 +98,10 @@ final class DefinitionProvider(
       if (path.isScalaFilename) {
         compilers()
           .definition(params, token)
-          .map(reportBuilder.setCompilerResult)
           .map {
-            case res if res.isEmpty => Some(res)
+            case res if res.isEmpty =>
+              reportBuilder.setCompilerResult(res)
+              Some(res)
             case res =>
               val pathToDef = res.locations.asScala.head.getUri.toAbsolutePath
               Some(
@@ -582,7 +583,7 @@ class DefinitionProviderReportBuilder(
 
   def build(): Option[Report] =
     compilerDefn match {
-      case Some(compilerDefn) if !foundScalaDocDef =>
+      case Some(compilerDefn) if !foundScalaDocDef && compilerDefn.isEmpty =>
         Some(
           Report(
             "empty-definition",