fix: don't show incorrect docs for inner methods

scalameta · Jan 13, 2025 · 08c5918 · 08c5918
1 parent cdf4dcd
commit 08c5918
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 6 deletions.
diff --git a/mtags/src/main/scala-3/scala/meta/internal/mtags/MtagsEnrichments.scala b/mtags/src/main/scala-3/scala/meta/internal/mtags/MtagsEnrichments.scala
@@ -1,5 +1,7 @@
 package scala.meta.internal.mtags
 
+import java.util.Optional
+
 import scala.annotation.tailrec
 import scala.util.control.NonFatal
 
@@ -28,6 +30,7 @@ import dotty.tools.dotc.core.Types.Type
 import dotty.tools.dotc.core.Types.TypeBounds
 import dotty.tools.dotc.interactive.Interactive
 import dotty.tools.dotc.interactive.InteractiveDriver
+import dotty.tools.dotc.transform.SymUtils.isLocal
 import dotty.tools.dotc.util.SourcePosition
 import dotty.tools.dotc.util.Spans
 import dotty.tools.dotc.util.Spans.Span
@@ -248,12 +251,14 @@ object MtagsEnrichments extends ScalametaCommonEnrichments:
             symbol.maybeOwner.companion,
           ).filter(_ != NoSymbol) ++ symbol.allOverriddenSymbols
         else symbol.allOverriddenSymbols
-
-      val documentation = search.documentation(
-        sym,
-        () => parentSymbols.map(toSemanticdbSymbol).toList.asJava,
-        contentType
-      )
+      val documentation =
+        if symbol.isLocal then Optional.empty
+        else
+          search.documentation(
+            sym,
+            () => parentSymbols.map(toSemanticdbSymbol).toList.asJava,
+            contentType
+          )
       if documentation.isPresent then Some(documentation.get())
       else None
     end symbolDocumentation

diff --git a/tests/cross/src/test/scala/tests/hover/HoverDocSuite.scala b/tests/cross/src/test/scala/tests/hover/HoverDocSuite.scala
@@ -527,4 +527,18 @@ class HoverDocSuite extends BaseHoverSuite {
                 |""".stripMargin
     )
   )
+
+  check(
+    "i7093",
+    """|object O {
+       |  /** Ooopsie daisy */
+       |  val computeLogicOwners: Unit = {
+       |    /** This is a comment */
+       |    <<def logi@@cOwners = ???>>
+       |    ???
+       |  }
+       |}
+       |""".stripMargin,
+    """def logicOwners: Nothing""".hover.stripMargin
+  )
 }