Make dom.URL.searchParams readonly (val) #871
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URL.searchParams
is a readonly field. The URLSearchParams object itself is mutable, but the reference is immutable and stable.https://url.spec.whatwg.org/#dom-url-searchparams
https://developer.mozilla.org/en-US/docs/Web/API/URL/searchParams
Note – in JS strict mode (typical for JS bundlers),
const url = new URL('http://localhost/').searchParams = new URLSearchParams({foo: "123"})
throws aTypeError
saying that searchParams is a readonly field, but in the browser dev console, such an assignment will fail silently instead. You can check that the assignment failed by printingurl.searchParams.size == 0
or comparing the new and old references.My testing and reading of the spec seems to confirm that it should be a
val
, not adef
, at least I couldn't find anything contradicting that.