Merge pull request #253 from sbrunner/better-line-image

Better line dev image size
sbrunner · Aug 26, 2022 · 93c40d6 · 93c40d6
2 parents b11c447 + 50865cf
commit 93c40d6
Show file tree

Hide file tree

Showing 14 changed files with 5 additions and 5 deletions.
diff --git a/.github/workflows/main.yaml b/.github/workflows/main.yaml
@@ -49,10 +49,10 @@ jobs:
           poetry run python --version
           [ "$(python3 --version)" == "$(poetry run python --version)" ]
 
-      - run: >
-          poetry run coverage run --source=deskew --module pytest --durations=0 --verbose --color=yes
-          --profile --profile-svg --junitxml=results/test-reports/junit.xml tests &&
-          poetry run coverage report &&
+      - run: |
+          poetry run coverage run --source=deskew --module pytest --durations=0 --verbose --color=yes \
+          --profile --profile-svg --junitxml=results/test-reports/junit.xml tests
+          poetry run coverage report
           poetry run coverage html --directory=results/coverage
 
       - uses: actions/upload-artifact@v3

diff --git a/deskew/__init__.py b/deskew/__init__.py
@@ -204,7 +204,7 @@ def determine_skew_debug_images(
         debug_images.append(("hough_transform", cv2.imread(file.name)))
 
     # Detected lines
-    _, axe = plt.subplots(figsize=(15, 6))
+    _, axe = plt.subplots(figsize=(image.shape[0] / 100, image.shape[1] / 100))
 
     axe.imshow(image, cmap=cm.gray)
     axe.set_ylim((image.shape[0], 0))

diff --git a/tests/debug-images-detected_lines-90-many-peaks.expected.png b/tests/debug-images-detected_lines-90-many-peaks.expected.png
diff --git a/tests/debug-images-detected_lines-90-min-max-inverted.expected.png b/tests/debug-images-detected_lines-90-min-max-inverted.expected.png
diff --git a/tests/debug-images-detected_lines-90-min-max-negative.expected.png b/tests/debug-images-detected_lines-90-min-max-negative.expected.png
diff --git a/tests/debug-images-detected_lines-90-min-max-positive.expected.png b/tests/debug-images-detected_lines-90-min-max-positive.expected.png
diff --git a/tests/debug-images-detected_lines-90-min-max.expected.png b/tests/debug-images-detected_lines-90-min-max.expected.png
diff --git a/tests/debug-images-detected_lines-90.expected.png b/tests/debug-images-detected_lines-90.expected.png
diff --git a/tests/debug-images-detected_lines-many-peaks.expected.png b/tests/debug-images-detected_lines-many-peaks.expected.png
diff --git a/tests/debug-images-detected_lines-min-max-inverted.expected.png b/tests/debug-images-detected_lines-min-max-inverted.expected.png
diff --git a/tests/debug-images-detected_lines-min-max-negative.expected.png b/tests/debug-images-detected_lines-min-max-negative.expected.png
diff --git a/tests/debug-images-detected_lines-min-max-positive.expected.png b/tests/debug-images-detected_lines-min-max-positive.expected.png
diff --git a/tests/debug-images-detected_lines-min-max.expected.png b/tests/debug-images-detected_lines-min-max.expected.png
diff --git a/tests/debug-images-detected_lines.expected.png b/tests/debug-images-detected_lines.expected.png