Filter by items in watch list in people view #671
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps the filter button on top should be made visible and use that instead? |
AlexPerathoner
force-pushed
the
feature/person-filter-on-my-list
branch
2 times, most recently
from
dda1a28 to
54cafbd
Compare
AlexPerathoner
force-pushed
the
feature/person-filter-on-my-list
branch
from
54cafbd to
1585ed1
Compare
IRHM
added a commit
that referenced
this pull request
Dec 1, 2024
Port based on #671 with changes. Co-Authored-By: Alex Perathoner <[email protected]>
IRHM
added a commit
that referenced
this pull request
Dec 1, 2024
Port based on #671 with changes. Co-authored-by: Alex Perathoner <[email protected]>
|
Thank you for working on this and for the idea in the first place! I took your code and modified it in #704. It seems more responsive for larger lists now (wrote in more detail in the PR description), I hope you agree if you ever try it out. I co-authored you on the commit since I used your code as a base, I hope that is okay! I'll close this one in favor of that one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #619
Changes made
#670 should be reviewed first
Added checkbox in people view to filter items to only those which are already in the watch list