Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Extend supported file types #1 #27

Merged
merged 11 commits into from
Oct 14, 2024

Conversation

alexstocker
Copy link
Contributor

src/index.ts Outdated Show resolved Hide resolved
src/App.vue Show resolved Hide resolved
src/App.vue Outdated Show resolved Hide resolved
src/App.vue Outdated Show resolved Hide resolved
Copy link
Owner

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
I tested and some files were not opened or atleast properly but for now it is good to be merged.
Thanks for your effort and time. ❤️

@saw-jan saw-jan merged commit cddef5f into saw-jan:master Oct 14, 2024
1 check passed
@alexstocker
Copy link
Contributor Author

@saw-jan could you please provide files which fail to open? I would like to investigate on it.

@saw-jan
Copy link
Owner

saw-jan commented Oct 14, 2024

@saw-jan could you please provide files which fail to open? I would like to investigate on it.

it was just too big that's why I was not able to see it at first. But I will send you the files

@saw-jan
Copy link
Owner

saw-jan commented Oct 14, 2024

Here is the model that was too big and only visible when rotating. Also, there's some problem with auth
Mclaren.zip

@alexstocker
Copy link
Contributor Author

Here is the model that was too big and only visible when rotating. Also, there's some problem with auth Mclaren.zip

@saw-jan Thanx!

Model size
we could think about re-scaling the model on the fly if suitable and/or get rid of hard coded min and max orbit distances

File size
when it comes to support different types of 3D standards we are going to face rendering limitations by the browser or better to say the underlying hardware resources and the support of theme (os depending), pretty soon (keywords: webgl, level of detail, shading, lights ...). Even if a huge file could be loaded into memory, this does not mean that the performance of rendering the scene will meet the user's expectations.

Auth Issue
[CONFIRM] It's pretty strange facing auth showing up on loading the model you provided. Did not notice something like this on any other model. This is maybe FBX related, but I am not sure. Still investigating.

image

@alexstocker
Copy link
Contributor Author

alexstocker commented Oct 14, 2024

@saw-jan To come to an end. It looks like missing materials/textures. Even Blender is blaming about ;-)

...
FBX import: Materials & Textures...
Error, could not find any file path in  FBXElem(id=b'Texture', props=[1961718568848, b'Map #2138625263\x00\x01Texture', b''], props_type=bytearray(b'LSS'), elems=[FBXElem(id=b'Type', props=[b'TextureVideoClip'],
...
	FBX import: Assign textures...
WARNING: material link b'3dsMax|LayeredMtlPb|mixmaps|mixmaps[0]' ignored
WARNING: material link b'3dsMax|CoronaMtlPb|texmapDiffuse' ignored
WARNING: material link b'3dsMax|CoronaMtlPb|texmapReflect' ignored
WARNING: material link b'3dsMax|CoronaMtlPb|texmapReflectGlossiness' ignored
WARNING: material link b'3dsMax|CoronaMtlPb|texmapBump' ignored
WARNING: material link b'3dsMax|CoronaMtlPb|texmapDiffuse' ignored
WARNING: material link b'3dsMax|CoronaMtlPb|texmapTranslucency' ignored
WARNING: material link b'3dsMax|CoronaMtlPb|texmapScatterColor' ignored
WARNING: material link b'3dsMax|LayeredMtlPb|mixmaps|mixmaps[0]' ignored
WARNING: material link b'3dsMax|CoronaMtlPb|texmapDiffuse' ignored
WARNING: material link b'3dsMax|CoronaMtlPb|texmapReflect' ignored
WARNING: material link b'3dsMax|CoronaMtlPb|texmapReflectGlossiness' ignored
WARNING: material link b'3dsMax|CoronaMtlPb|texmapBump' ignored
		Done (0.157351 sec)
...

Result Trying to load non existing textures from non existing texture folder causing auth request

@saw-jan
Copy link
Owner

saw-jan commented Oct 14, 2024

when it comes to support different types of 3D standards we are going to face rendering limitations by the browser or better to say the underlying hardware resources and the support of theme (os depending), pretty soon (keywords: webgl, level of detail, shading, lights ...). Even if a huge file could be loaded into memory, this does not mean that the performance of rendering the scene will meet the user's expectations.

yeah, there're a lot of tradeoffs to consider. we can only try to minimize them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants