Getting DataHolder in onCreate() or onCreateView()

* Calling it in UI Thread only * To mitigate Fragment detached crash scenarios
saurabhsjoshi · Jul 22, 2015 · 074b09c · 074b09c
1 parent f1355d6
commit 074b09c
Show file tree

Hide file tree

Showing 7 changed files with 27 additions and 13 deletions.
diff --git a/app/src/main/java/com/karthikb351/vitinfo2/activity/DetailsActivity.java b/app/src/main/java/com/karthikb351/vitinfo2/activity/DetailsActivity.java
@@ -56,13 +56,14 @@ public class DetailsActivity extends AppCompatActivity {
     protected void onCreate(Bundle savedInstanceState) {
         super.onCreate(savedInstanceState);
 
+        List<Course> courseList = ((MainApplication) getApplication()).getDataHolderInstanceInitialized().getCourses();
 
         Intent intent = getIntent();
         if (intent.hasExtra(Constants.INTENT_EXTRA_CLASS_NUMBER)) {
             setContentView(R.layout.activity_details);
             initToolbar();
             loadProgress = (ProgressBar) findViewById(R.id.progress_bar_details);
-            new LoadCourseTask().execute(intent.getIntExtra(Constants.INTENT_EXTRA_CLASS_NUMBER, -1));
+            new LoadCourseTask(courseList).execute(intent.getIntExtra(Constants.INTENT_EXTRA_CLASS_NUMBER, -1));
 
         } else {
             setContentView(R.layout.app_message_not_available);
@@ -94,6 +95,13 @@ public boolean onOptionsItemSelected(MenuItem item) {
     }
 
     private class LoadCourseTask extends AsyncTask<Integer, Void, Course> {
+
+        private List<Course> courses;
+
+        LoadCourseTask(List<Course> courses) {
+            this.courses = courses;
+        }
+
         @Override
         protected void onPreExecute() {
             loadProgress.setVisibility(View.VISIBLE);
@@ -129,8 +137,7 @@ protected Course doInBackground(Integer... params) {
                 return null;
             }
 
-            List<Course> courseList = ((MainApplication) getApplication()).getDataHolderInstanceInitialized().getCourses();
-            for (Course courseItem : courseList) {
+            for (Course courseItem : courses) {
                 if (courseItem.getClassNumber() == classNumber) {
                     foundCourse = courseItem;
                 }
@@ -139,5 +146,4 @@ protected Course doInBackground(Integer... params) {
         }
     }
 
-
 }
diff --git a/app/src/main/java/com/karthikb351/vitinfo2/activity/MainActivity.java b/app/src/main/java/com/karthikb351/vitinfo2/activity/MainActivity.java
@@ -177,15 +177,17 @@ public void pullToRefresh(final ResultListener callback) {
             @Override
             public void onSuccess() {
                 initializeData();
-                if (callback != null)
+                if (callback != null) {
                     callback.onSuccess();
+                }
                 EventBus.getDefault().post(new RefreshFragmentEvent());
             }
 
             @Override
             public void onFailure(Status status) {
-                if (callback != null)
+                if (callback != null) {
                     callback.onFailure(status);
+                }
                 Toast.makeText(MainActivity.this, status.getMessage(), Toast.LENGTH_SHORT).show();
             }
         };

diff --git a/app/src/main/java/com/karthikb351/vitinfo2/fragment/LoginFragment.java b/app/src/main/java/com/karthikb351/vitinfo2/fragment/LoginFragment.java
@@ -191,8 +191,8 @@ public void run() {
             public void onSuccess() {
                 try {
                     ((MainApplication) getActivity().getApplication()).getDataHolderInstance().refreshData(getActivity(), resultListener);
-                } catch (NullPointerException ignore){}
-
+                } catch (NullPointerException ignore){
+                }
             }
 
             @Override

diff --git a/app/src/main/java/com/karthikb351/vitinfo2/fragment/grades/GradesFragment.java b/app/src/main/java/com/karthikb351/vitinfo2/fragment/grades/GradesFragment.java
@@ -85,7 +85,6 @@ public View onCreateView(LayoutInflater inflater, @Nullable ViewGroup container,
 
     public void initialize() {
         cgpa = ((MainApplication) getActivity().getApplication()).getDataHolderInstanceInitialized().getCgpa();
-        grades = ((MainApplication) getActivity().getApplication()).getDataHolderInstanceInitialized().getGrades();
         gradeCounts = ((MainApplication) getActivity().getApplication()).getDataHolderInstanceInitialized().getGradeCounts();
         semesterWiseGrades = ((MainApplication) getActivity().getApplication()).getDataHolderInstanceInitialized().getSemesterWiseGrades();
 

diff --git a/app/src/main/java/com/karthikb351/vitinfo2/fragment/messages/MessagesFragment.java b/app/src/main/java/com/karthikb351/vitinfo2/fragment/messages/MessagesFragment.java
@@ -65,16 +65,23 @@ public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle sa
     }
 
     public void initialize() {
-        messages = ((MainApplication) getActivity().getApplication()).getDataHolderInstanceInitialized().getMessages();
-        Collections.reverse(messages);
+        initializeData();
         layoutManager = new LinearLayoutManager(getActivity());
         messageListAdapter = new MessageListAdapter(getActivity(), messages);
         recyclerView = (RecyclerView) rootView.findViewById(R.id.recycler_view_messages);
         recyclerView.setLayoutManager(layoutManager);
         recyclerView.setAdapter(messageListAdapter);
         String Title = getActivity().getResources().getString(R.string.fragment_messages_title);
         getActivity().setTitle(Title);
+    }
 
+    private void initializeData() {
+        try {
+            messages = ((MainApplication) getActivity().getApplication()).getDataHolderInstanceInitialized().getMessages();
+            Collections.reverse(messages);
+            messageListAdapter.notifyDataSetChanged();
+        } catch (Exception ignore) {
+        }
     }
 
     @Override

diff --git a/app/src/main/java/com/karthikb351/vitinfo2/fragment/timetable/TimetableDayFragment.java b/app/src/main/java/com/karthikb351/vitinfo2/fragment/timetable/TimetableDayFragment.java
@@ -111,6 +111,7 @@ public void onFailure(Status status) {
     }
 
     private void initializeData() {
+        courses = ((MainApplication) getActivity().getApplication()).getDataHolderInstanceInitialized().getCourses();
         new LoadDayTask().execute();
     }
 
@@ -148,7 +149,6 @@ protected void onPreExecute() {
         @Override
         protected List<Pair<Course, Timing>> doInBackground(Void... params) {
             List<Pair<Course, Timing>> finalArray = new ArrayList<>();
-            courses = ((MainApplication) getActivity().getApplication()).getDataHolderInstanceInitialized().getCourses();
             for (Course course : courses) {
                 Timing lastTiming = new Timing();
                 for (Timing timing : course.getTimings()) {

diff --git a/app/src/main/java/com/karthikb351/vitinfo2/fragment/today/TodayFragment.java b/app/src/main/java/com/karthikb351/vitinfo2/fragment/today/TodayFragment.java
@@ -119,6 +119,7 @@ public void onFailure(Status status) {
     }
 
     private void initializeData() {
+        courses = ((MainApplication) getActivity().getApplication()).getDataHolderInstanceInitialized().getCourses();
         new LoadTodayTask().execute();
     }
 
@@ -169,7 +170,6 @@ protected void onPreExecute() {
         @Override
         protected List<Pair<Course, Timing>> doInBackground(Void... params) {
             List<Pair<Course, Timing>> finalArray = new ArrayList<>();
-            courses = ((MainApplication) getActivity().getApplication()).getDataHolderInstanceInitialized().getCourses();
             for (Course course : courses) {
                 Timing lastTiming = new Timing();
                 if (course.getTimings() != null) {