Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolves #245 #246

Merged
merged 2 commits into from
Aug 8, 2024
Merged

resolves #245 #246

merged 2 commits into from
Aug 8, 2024

Conversation

waggledans
Copy link
Contributor

@waggledans waggledans commented Aug 7, 2024

One-line summary

Issue : #245

Description

This is a breaking change

Removing the --headless option that was mapped to the us-east-1 datacenter.

      --headless  if set to true you are accessing the headless Sauce instances
                  (this discards the `region` option) [boolean] [default: false]

Types of Changes

What types of changes does your code introduce? Keep the ones that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • Configuration change

Review

List of tasks the reviewer must do to review the PR

  • Tests
  • Documentation
  • CHANGELOG

Deployment Notes

These should highlight any db migrations, feature toggles, etc.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did I merge them in the wrong order?
Can you please fix the conflicts?

@waggledans
Copy link
Contributor Author

Did I merge them in the wrong order? Can you please fix the conflicts?

yup, the other one was WIP, to be merged after this one. reverted

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you, @waggledans!

@diemol diemol merged commit c423bdc into main Aug 8, 2024
6 checks passed
@diemol diemol deleted the dans-headless branch August 8, 2024 19:18
@diemol diemol mentioned this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants