Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some flaky tests #56

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

hmhealey
Copy link

@hmhealey hmhealey commented Jan 7, 2025

These tests aren't related to mattermost/mattermost#29224, but they all were flaky when running the tests for it.

The first set of tests failed on CI in https://automation-dashboard.vercel.app/cycle/12422671923_1-44d9567-pr-onprem-ent, but they passed when I ran them locally. I ran the tests again to verify that in https://automation-dashboard.vercel.app/cycle/12641178131_1-44d9567-pr-onprem-ent, and then a different test failed, so I added that as well

Copy link

vercel bot commented Jan 7, 2025

@hmhealey is attempting to deploy a commit to the Saturnino Abril's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Jan 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
automation-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 0:43am

@saturninoabril
Copy link
Owner

Thanks @hmhealey for taking the time for this PR. I'll put this on hold for now since "known issue" submission is no longer in use in favor of auto-detecting flaky tests based on past results (from nightly builds). Likely, the "known issue" will be reserved to those that were product/system/infra bug with corresponding Jira ticket. I know there's an instruction to submit a PR here and it's something I'm going to update too. I'll take a look this week.

@hmhealey
Copy link
Author

hmhealey commented Jan 9, 2025

@saturninoabril Is there still a way with that process to manually add flaky tests that aren't caught on nightly builds? My worry with just detecting them from nightly builds is that they don't run as often as PR builds which means they're less likely to encounter flaky behaviour

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants