Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

files: Don't truncate filename to just the basename #919

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jlewi
Copy link

@jlewi jlewi commented Jan 2, 2025

Describe the change
When creating OpenAI Files, I want to be able to set the Filename to a file URI and not just the result of path.Base(filename).

The Assistants API will return the FileName in responses. If we truncate the URI we may not be able to locate the file.
If a caller wants to just use the baseName then they can set this ins the FileBytesRequest by setting Name as desired.

Currently CreateFileBytes passes the user set Name to CreateFormFileReader which truncates the name to the basename.

The PR would be a breaking change for anyone relying on the current behavior. If a non breaking change is preferred we could add options or a different method.

Provide OpenAI documentation link
Provide a relevant API doc from https://platform.openai.com/docs/api-reference
https://platform.openai.com/docs/api-reference/files/object

Describe your solution
Describe how your changes address the problem or how they add the feature. This should include a brief description of your approach and any new libraries or dependencies you're using.

Remove the call to path.Base

Tests
Briefly describe how you have tested these changes. If possible — please add integration tests.

Additional context
Add any other context or screenshots or logs about your pull request here. If the pull request relates to an open issue, please link to it.

Issue: #XXXX

@jlewi
Copy link
Author

jlewi commented Jan 2, 2025

I'm not sure why golang is failing with the following error

run golangci-lint
  Running [/home/runner/golangci-lint-1.63.2-linux-amd64/golangci-lint run --out-format=github-actions] in [] ...
  Error: Comment should end in a period (godot)

I suspect its not coming from this PR as there are no comments added in this PR. The output doesn't indicate the light number in question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant