files: Don't truncate filename to just the basename #919
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
When creating OpenAI Files, I want to be able to set the Filename to a file URI and not just the result of path.Base(filename).
The Assistants API will return the FileName in responses. If we truncate the URI we may not be able to locate the file.
If a caller wants to just use the baseName then they can set this ins the FileBytesRequest by setting
Name
as desired.Currently CreateFileBytes passes the user set Name to CreateFormFileReader which truncates the name to the basename.
The PR would be a breaking change for anyone relying on the current behavior. If a non breaking change is preferred we could add options or a different method.
Provide OpenAI documentation link
Provide a relevant API doc from https://platform.openai.com/docs/api-reference
https://platform.openai.com/docs/api-reference/files/object
Describe your solution
Describe how your changes address the problem or how they add the feature. This should include a brief description of your approach and any new libraries or dependencies you're using.
Remove the call to path.Base
Tests
Briefly describe how you have tested these changes. If possible — please add integration tests.
Additional context
Add any other context or screenshots or logs about your pull request here. If the pull request relates to an open issue, please link to it.
Issue: #XXXX