scale bar: slight performance improvement #235
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after all, the
defaultScaleBarMeasures
is now called every frame.(If it wasn't
@Composable
, it could also beremember
ed)I was previously looking into performance improvements on the scalebar, after all, quite a lot is going on there. But basically any attempt to let the scalebar compose less often is sabotaged by the fact that any change in latitude or zoom will make it recompose anyway, as the
metersPerDp
changes.metersPerDp
could maybe be rounded, the trick would be to find out at which precision it starts to matter (i.e. be visible on the scalebar). Then, it would generally not recompose when scrolling around in an area, only when one zooms.