Fix issues with string/atom mix in changeset

lib/sanbase/metric/registry/change_suggestion.ex

@@ -160,7 +160,9 @@ defmodule Sanbase.Metric.Registry.ChangeSuggestion do
     # After change suggestion is applied, put the metric in a unverified state and mark
     # is as not synced. Someone needs to manually verify the metric after it is tested.
     # When the data is synced between stage and prod, the sync status will be updated.
-    # Note: Keep the keys as strings, not atoms, so the map is not mixed
+
+    # Convert all keys to strings so we don't get error if atom keys come from some caller
+    params = Map.new(params, fn {k, v} -> {to_string(k), v} end)
     params = Map.merge(params, %{"is_verified" => false, "sync_status" => "not_synced"})
 
     case Registry.changeset(registry, params) do

lib/sanbase/metric/registry/sync.ex

@@ -95,7 +95,7 @@ defmodule Sanbase.Metric.Registry.Sync do
   end
 
   defp start_sync(sync) do
-    url = get_sync_target_url() |> IO.inspect()
+    url = get_sync_target_url()
 
     json = %{
       "sync_uuid" => sync.uuid,

test/sanbase/metric_registry/metric_registry_sync_test.exs

@@ -3,8 +3,6 @@ defmodule Sanbase.MetricRegistrySyncTest do
   alias Sanbase.Metric.Registry
 
   test "syncing", context do
-    Req.post("http://localhost:4000/sync_metric_registry?secret=secret_only_on_prod")
-
     [m1_id, m2_id] = create_sync_requirements()
 
     {:ok, m1} = Registry.by_id(m1_id)

test/sanbase/metric_registry/metric_registry_test.exs

@@ -1,4 +1,4 @@
-dsefmodule Sanbase.MetricRegistyTest do
+defmodule Sanbase.MetricRegistyTest do
   use Sanbase.DataCase
   import ExUnit.CaptureLog